bpo-45582: Change the folder location of PGO-instrumented builds on Windows#29941
Closed
neonene wants to merge 6 commits intopython:mainfrom
neonene:bpo-45582_pgo
Closed
bpo-45582: Change the folder location of PGO-instrumented builds on Windows#29941neonene wants to merge 6 commits intopython:mainfrom neonene:bpo-45582_pgo
neonene wants to merge 6 commits intopython:mainfrom
neonene:bpo-45582_pgo
Conversation
Member
|
It would be good to understand what the change in getpath is that caused this to start breaking, as it may impact other users as well. That said, I approve of this change anyway. |
Contributor
Author
|
I'll look into the change further. |
Contributor
Author
|
Additionally, I've posted an alternative PR (#30014) which leaves the instrumented folder as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Python cannot find paths correctly at the PGO profiling time.
Even if envvars are set, test_embed fails.
This issue does not exist when the PGO-instrumented build is located as high as the product build in directory level.
https://bugs.python.org/issue45582