bpo-46038: Mark /configure file as generated in .gitattributes#30031
Closed
arhadthedev wants to merge 2 commits intopython:mainfrom
Closed
bpo-46038: Mark /configure file as generated in .gitattributes#30031arhadthedev wants to merge 2 commits intopython:mainfrom
arhadthedev wants to merge 2 commits intopython:mainfrom
Conversation
configure is regenerated from configure.ac using a custom container with appropriate version of tools (quay.io/tiran/cpython_autoconf by Christian Heimes). As a result, configure falls into the same category as files generated by Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churn of these artifacts, they are marked in .gitattributes as generated so GitHub Pull Request Diff Viewer collapses them into a short notification. This commit does the same for configure. Actually, configure diff is so large that sometimes it crosses a threshold and GitHub collapses it by force with "Large diffs are not rendered by default" or even "xxx additions, yyy deletions not shown because the diff is too large. Please use a local Git client to view these changes". See pythonGH-29756 as an extreme example and <https://github.com/python/cpython/commits/main/configure> for an average.
tiran
reviewed
Dec 10, 2021
tiran
approved these changes
Dec 10, 2021
erlend-aasland
approved these changes
Dec 10, 2021
Contributor
|
I'd say we backport this to 3.10 and 3.9, @tiran. |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
Author
|
Closing in favor of #30745. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configureis regenerated from configure.ac using a custom container with appropriate version of tools (quay.io/tiran/cpython_autoconf by Christian Heimes). As a result, configure falls into the same category as files generated by Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churn of these artifacts, they are marked in .gitattributes as generated so GitHub Pull Request Diff Viewer collapses them into a short notification. This pull request does the same for configure.Actually, configure diff is so large that sometimes it crosses a threshold and GitHub collapses it by force with "Large diffs are not rendered by default" or even "xxx additions, yyy deletions not shown because the diff is too large. Please use a local Git client to view these changes". See GH-29756 as an extreme example and https://github.com/python/cpython/commits/main/configure for an average.
I believe this PR does not need a NEWS entry because the change is relevant only for a GitHub-hosted copy.
https://bugs.python.org/issue46038