[2.7] bpo-31170: Update libexpat from 2.2.3 to 2.2.4 (#3315)#3351
[2.7] bpo-31170: Update libexpat from 2.2.3 to 2.2.4 (#3315)#3351vstinner wants to merge 4 commits intopython:2.7from vstinner:expat224_27
Conversation
* bpo-31170: Update libexpat from 2.2.3 to 2.2.4 Fix copying of partial characters for UTF-8 input (libexpat bug 115): libexpat/libexpat#115 * Add NEWS entry. (cherry picked from commit 759e30e)
tiran
left a comment
tiran
left a comment
There was a problem hiding this comment.
Breaks Windows builds:
..\Modules\expat\xmltok.c(34): fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory [C:\projects\cpython\PCbuild\pyexpat.vcxproj]
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
The standard header stdbool.h is not available with old Visual Studio compilers Cherry-picked from libexpat b4b89c2ab0cc5325a41360c25ef9d2ccbe617e5c.
|
"Breaks Windows builds: ..\Modules\expat\xmltok.c(34): fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory [C:\projects\cpython\PCbuild\pyexpat.vcxproj]" I spent 15 minutes to write a fix for libexpat. But i was working on the 2.2.4 branch, in fact the bug is already fixed upstream: libexpat/libexpat@b4b89c2 So I cherry-picked the fix. |
…pilation. Cherry-picked from libexpat commit e0b290eb3d8f4c4b45137a7d7f4f8db812145bd2
vstinner
dismissed
tiran’s stale review
Yeah, tests pass on Windows (AppVeyor) :-)
|
Thanks. Since this is going into 2.7.14 final, I'll deal with it. |
6 participants
Fix copying of partial characters for UTF-8 input (libexpat bug 115):
libexpat/libexpat#115
(cherry picked from commit 759e30e)
https://bugs.python.org/issue31170