Deduplicated float tests and unified in floats/mod.rs #148206

xonx4l · 2025-10-28T12:23:42Z

In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in #141726.

The moved float tests are:

-> test_powf
-> test_exp
-> test_exp2
-> test_ln
-> test_log_generic
-> test_log2
-> test_log10
-> test_asinh
-> test_acosh
-> test_atanh
-> test_gamma
-> test_ln_gamma

Closes: #141726

r? tgross35

rustbot · 2025-10-28T12:23:47Z

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

library/std/tests/floats/lib.rs

xonx4l · 2025-11-11T12:19:21Z

Any update @bjorn3 ?

bjorn3 · 2025-11-11T12:22:56Z

CI is still failing.

xonx4l · 2025-11-11T12:27:03Z

CI is still failing.

ok let me fix .

rustbot · 2025-11-14T08:23:07Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

LorrensP-2158466 · 2025-11-17T23:39:14Z

library/coretests/tests/floats/mod.rs

+        let inf: Float = Float::INFINITY;
+        let neg_inf: Float = Float::NEG_INFINITY;
+        assert_biteq!((10.0 as Float).log(10.0), 1.0);
+        assert_approx_eq!((2.3 as Float).log(3.5), 0.664858, Float::LOG_APPROX);


This test here for f128 will fail because the precision is much higher, if you look at the original test, the expected value is much more precise than what you have written:

assert_approx_eq!(2.3f128.log(3.5), 0.66485771361478710036766645911922010272, TOL);

When testing higher precision floats, you need much more precise expected values or the tests will fail, as they do now. In Miri, this is even more strict.

If you look at the source of f16 constants, they use much more digits after the decimal point than needed:

pub const PI: f16 = 3.14159265358979323846264338327950288_f16;

So you should probably do that as well.

Okay it makes sense . Thanks

tgross35 · 2025-11-19T14:09:50Z

Thank you for the final cleanup here. Until CI is fixed,
@rustbot author

rustbot · 2025-11-19T14:09:55Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

xonx4l · 2025-11-19T18:27:09Z

Thank you for the final cleanup here. Until CI is fixed, @rustbot author

Will finish this as soon as possible . A bit busy these days.

rustbot · 2026-01-13T20:48:09Z

Some changes occurred in GUI tests.

cc @GuillaumeGomez

GuillaumeGomez · 2026-01-13T21:18:09Z

tests/rustdoc-gui/notable-trait.goml

    block {
        call-function: ("check-notable-tooltip-position", {"x": |x|, "i_x": |i_x|})
-        assert-count: ("//*[@class='tooltip popover']", 0)
+        assert-count: ("//*[@class='tooltip popover']", 1)


Please remove these changes.

rust-bors · 2026-01-14T06:54:59Z

☔ The latest upstream changes (presumably #151087) made this pull request unmergeable. Please resolve the merge conflicts.

xonx4l · 2026-01-15T20:53:02Z

@tgross35 made all the suggested changes and squashed the commits . Thanks

xonx4l · 2026-01-15T20:53:08Z

@rustbot ready

rustbot · 2026-01-16T18:11:58Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot assigned tgross35 Oct 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 28, 2025