[5.x] Allow config values to be used in forms#11403
Merged
jasonvarga merged 2 commits intostatamic:5.xfrom Jan 21, 2026
Merged
Conversation
Contributor
Author
|
@jasonvarga it's been almost a year now - would you consider this for v6? |
Contributor
|
@jasonvarga I think this might have broken using form field antlers in the form config. For example if i set as a test, i added some logging to demonstrate: which gives the following output: This was working before the change. |
jasonvarga
added a commit
that referenced
this pull request
Jan 22, 2026
This reverts commit 408767d.
Member
|
Reverted in 5.73.1. @FrittenKeeZ Sorry about this. Happy to try this again with some more care around the bug this caused. And tests. |
Contributor
Author
|
@jasonvarga It's quite alright, we've just never used the form variables in the configuration, so I never thought about that case. Seems like some general tests are missing for forms 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is described here: statamic-rad-pack/mailchimp#137
It's not a breaking change, but is necessary for the above issue to be resolved - unless there's another mysterious way to hook into data to fix it?