[5.x] Fix multi-site URL invalidation in ApplicationCacher#13793
Merged
jasonvarga merged 2 commits into5.xfrom Feb 2, 2026
Merged
[5.x] Fix multi-site URL invalidation in ApplicationCacher#13793jasonvarga merged 2 commits into5.xfrom
ApplicationCacher#13793jasonvarga merged 2 commits into5.xfrom
Conversation
joshuablum
changed the title
ApplicationCacher
jasonvarga
deleted the
fix-multi-site-url-invalidation-on-half-measure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
invalidateUrl()by now passing$domaintoforgetUrl(). This resulted in URL index issues in multi-site setups. Also extracts the domain from full URLs when$domainis null which can happen when running from the command line. Looks like this is just an issue withhalfmeasure and got fixed infullmeasure and theFileCacherin 2022 already, see #6621.Tests ensure that URL invalidation actually works correctly in a multi-site setup verifying the URL index is updated under the correct domain hash when
$domainis explicitly passed and then also verifies domain extraction works for CLI contexts.Should go into
6.xtoo.Reported by Christian J. through support, thanks!