Skip to content

Conversation

@tony
Copy link
Member

@tony tony commented Sep 11, 2022

Fixes #388

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #409 (eb8941d) into master (53be184) will decrease coverage by 11.88%.
The diff coverage is 88.52%.

@@             Coverage Diff             @@
##           master     #409       +/-   ##
===========================================
- Coverage   72.72%   60.83%   -11.89%     
===========================================
  Files          25       35       +10     
  Lines        2240     2727      +487     
  Branches        0      657      +657     
===========================================
+ Hits         1629     1659       +30     
- Misses        611      640       +29     
- Partials        0      428      +428     
Impacted Files Coverage Δ
src/libvcs/pytest_plugin.py 88.33% <88.33%> (ø)
tests/sync/test_git.py 96.21% <100.00%> (-2.71%) ⬇️
tests/sync/test_pytest_plugin.py 100.00% <100.00%> (ø)
tests/sync/test_svn.py 92.00% <100.00%> (-4.00%) ⬇️
src/libvcs/cmd/git.py 13.10% <0.00%> (-41.43%) ⬇️
src/libvcs/cmd/hg.py 40.50% <0.00%> (-29.63%) ⬇️
src/libvcs/cmd/svn.py 34.80% <0.00%> (-17.68%) ⬇️
src/libvcs/sync/git.py 65.44% <0.00%> (-9.20%) ⬇️
src/libvcs/sync/svn.py 41.48% <0.00%> (-8.89%) ⬇️
src/libvcs/sync/base.py 84.28% <0.00%> (-8.37%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Moving from conftest.py to pytest_plugin.py (which comes via a
setuptools entry point) requires a workaround to prevent loss
of coverage from real libtmux tests relying on our pytest plugin.

See also:
- https://pytest-cov.readthedocs.io/en/latest/plugins.html
- pytest-dev/pytest#935 (comment)
@tony tony force-pushed the pytest-plugin branch 3 times, most recently from 3225219 to 7c71ba7 Compare September 11, 2022 21:46
@tony tony merged commit a488b5b into master Sep 11, 2022
@tony tony deleted the pytest-plugin branch September 11, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create libvcs.testing module as a pytest plugin

1 participant