cmd(Git.rev_list): Fix variable expansion
#455
Merged
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
=======================================
Coverage 62.67% 62.67%
=======================================
Files 39 39
Lines 3445 3445
Branches 927 927
=======================================
Hits 2159 2159
Misses 770 770
Partials 516 516 ☔ View full report in Codecov by Sentry. |
tony
added a commit
to vcs-python/vcspull
that referenced
this pull request
Feb 17, 2024
tony
added a commit
to vcs-python/vcspull
that referenced
this pull request
Feb 17, 2024
tony
added a commit
to vcs-python/vcspull
that referenced
this pull request
Feb 17, 2024
See also: - vcs-python/libvcs#455 - Fixes #438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vcs-python/vcspull#438
Changes
Fix
Git.rev_list()Was not handling flags like
max_countcorrectly.