Improve Logged-In Users panel

[raamdev]

When Logged-In Users caching is disabled (the default), everything else in that panel (other than the option to enable Logged-In Users caching) should be greyed out, as none of the other options are applicable unless Logged-In Users caching is enabled. (This should work the same way the HTML Compressor panel works.)

While we're at it, the Enable HTML Compression for Logged-In Users? option from the HTML Compressor panel should be moved to the Logged-In Users panel, as it seems more appropriate there.

[raamdev]

Noting that this is complicated by the when_logged_in option having one of three possible values: 0, 1, and postload. (The ability to choose the value of 1 was dropped a long time ago and only exists for backwards-compatibility.) The JavaScript that is used by the HTML Compressor panel to fade out additional options currently looks for an integer value of >= 1, which does not work with a value of postload.

So, we'll either need to change the when_logged_in option so that instead of using postload it uses, perhaps, 2, or we'll need to adjust the JavaScript to consider the postload value. If we change the postload value, we'll need to write a Version Upgrade routine to change the value for existing sites who may have that option enabled.

[jaswrks]

The JavaScript that is used by the HTML Compressor panel to fade out additional options currently looks for an integer value of >= 1, which does not work with a value of postload.

Working Around This Issue

• In the select tag add data-enabled-strings="1,postload"

• Replace these lines with the following:

  plugin.enableDisable = function (event) {
      var $this = $(this),
      thisValue = $this.val(),
      thisName = $this.attr('name'),
      thisEnabledStrings = String($this.data('enabledStrings') || '1,2,3,4,5').split(/,+/);
  
      var enabled = $.inArray(thisValue, thisEnabledStrings) !== -1;

[raamdev]

@jaswsinc Thanks! :-)

You have a couple of bugs in that outline:

• "Replace these lines with the following"; doing that breaks the rest of the JavaScript below that section because these lines are part of the previous var statement.
• The outline does not completely solve the problem, because this line attaches plugin.EnableDisable only to select elements whose name ends with _enable ('select[name$="_enable\\]"]'), and the Logged-In Users option does not end with _enable (its value is when_logged_in). (I was banging my head against the table trying to figure out why the heck it wasn't working.)

So, do you suggest adding a second line that attaches when_logged_in to plugin.EnableDisable, or something else?

[renzms]

@raamdev

Hi Raam, are there things that need to be addressed first before I start working on this?

[jaswrks]

because these lines are part of the previous var statement.

Copy. I missed that, sorry :-)

plugin.EnableDisable only to select elements whose name ends with _enable ('select[name$="_enable]"]'), ... So, do you suggest adding a second line that attaches when_logged_in to plugin.EnableDisable, or something else?

We could alter the select so that it includes an explicit attempt to include the enable/disable functionality on a given <select> tag. So for instance, we can change this line to the following:

$('select[name$="_enable\\]"], select[data-toggle~="enable-disable"]', plugin.$menuPage).not('.-no-if-enabled').on('change', plugin.enableDisable).trigger('change');

and then on the <select> tag add the following attributes here.

data-toggle="enable-disable" data-enabled-strings="1,postload"

Example:

echo '      <p><select name="'.esc_attr(GLOBAL_NS).'[saveOptions][when_logged_in]" data-toggle="enable-disable" data-enabled-strings="1,postload">'."\n";

[raamdev]

@renzms writes...

Hi Raam, are there things that need to be addressed first before I start working on this?

I've assigned this to myself and already submitted a PR, so I'll take care of this one. :-)