fix(47597): preProcessFile incorrectly identifies imports in comments after a template literal type#47657

a-tarasyuk · 2022-01-29T09:41:55Z

Fixes #47597
Fixes #30878

src/services/preProcess.ts

DanielRosenwasser · 2022-03-11T18:58:02Z

@typescript-bot cherry-pick this to release-4.6

typescript-bot · 2022-03-11T18:58:04Z

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.6 on this PR at 4516fa8. You can monitor the build here.

DanielRosenwasser · 2022-03-11T18:59:15Z

@typescript-bot pack this

typescript-bot · 2022-03-11T18:59:16Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 4516fa8. You can monitor the build here.

typescript-bot · 2022-03-11T19:02:29Z

Hey @DanielRosenwasser, I've opened #48223 for you.

Component commits: 4516fa8 fix(47597): ignore commented imports following template expression

typescript-bot · 2022-03-11T19:18:02Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/121706/artifacts?artifactName=tgz&fileId=FED8D6B9AF71583AC05071AA11ECE85A2D500E9AFF6B5B4BE5829AFCA4F0B22002&fileName=/typescript-4.7.0-insiders.20220311.tgz"
    }
}

and then running npm install.

Component commits: 4516fa8 fix(47597): ignore commented imports following template expression Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [typescript](https://www.typescriptlang.org/) ([source](https://github.com/Microsoft/TypeScript)) | devDependencies | minor | [`4.5.5` -> `4.6.3`](https://renovatebot.com/diffs/npm/typescript/4.5.5/4.6.3) | --- ### Release Notes <details> <summary>Microsoft/TypeScript</summary> ### [`v4.6.3`](https://github.com/Microsoft/TypeScript/releases/v4.6.3) [Compare Source](microsoft/TypeScript@v4.6.2...v4.6.3) This release includes fixes for - [an incremental parsing bug caused by faulty error recovery logic](microsoft/TypeScript#47895) - [improved results from the TypeScript API's `preProcessFile` function](microsoft/TypeScript#47657) For the complete list of fixed issues, check out the - [fixed issues query for Typescript 4.6.0 (Beta)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.0%22+). - [fixed issues query for Typescript 4.6.1 (RC)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.1%22+). - [fixed issues query for Typescript 4.6.2 (Stable)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.2%22+). - [fixed issues query for Typescript 4.6.3 (Stable)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.3%22+). Downloads are available on: - [npm](https://www.npmjs.com/package/typescript) ### [`v4.6.2`](https://github.com/Microsoft/TypeScript/releases/v4.6.2) [Compare Source](microsoft/TypeScript@v4.5.5...v4.6.2) For release notes, check out the [release announcement](https://devblogs.microsoft.com/typescript/announcing-typescript-4-6/). For the complete list of fixed issues, check out the - [fixed issues query for Typescript 4.6.0 (Beta)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.0%22+). - [fixed issues query for Typescript 4.6.1 (RC)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.1%22+). - [fixed issues query for Typescript 4.6.2 (Stable)](https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.6.2%22+). Downloads are available on: - [npm](https://www.npmjs.com/package/typescript) - [Visual Studio 2022/2019](https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-46) ([Select new version in project options](https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017)) - [NuGet package](https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1242 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 29, 2022

a-tarasyuk force-pushed the fix/47597 branch from 9b93410 to 889b710 Compare January 29, 2022 10:27

sandersn requested review from andrewbranch and sandersn February 16, 2022 16:06

sandersn assigned andrewbranch Feb 16, 2022

DanielRosenwasser requested changes Feb 18, 2022

View reviewed changes

src/services/preProcess.ts Outdated Show resolved Hide resolved

a-tarasyuk force-pushed the fix/47597 branch from 889b710 to 097e2a5 Compare February 18, 2022 23:20

a-tarasyuk requested a review from DanielRosenwasser February 18, 2022 23:20

DanielRosenwasser reviewed Feb 19, 2022

View reviewed changes

src/services/preProcess.ts Outdated Show resolved Hide resolved

a-tarasyuk force-pushed the fix/47597 branch from 097e2a5 to 213dbe1 Compare February 19, 2022 10:17

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Backlog Bug PRs that fix a backlog bug labels Feb 19, 2022

a-tarasyuk requested a review from DanielRosenwasser February 19, 2022 10:19

a-tarasyuk force-pushed the fix/47597 branch from 213dbe1 to e41f88a Compare February 19, 2022 17:06

DanielRosenwasser reviewed Feb 22, 2022

View reviewed changes

src/services/preProcess.ts Outdated Show resolved Hide resolved

a-tarasyuk closed this Feb 22, 2022

a-tarasyuk reopened this Feb 23, 2022

a-tarasyuk force-pushed the fix/47597 branch from e41f88a to e1bf7cf Compare February 23, 2022 06:59

a-tarasyuk requested a review from DanielRosenwasser February 23, 2022 07:04

DanielRosenwasser reviewed Mar 11, 2022

View reviewed changes

src/services/preProcess.ts Outdated Show resolved Hide resolved

fix(47597): ignore commented imports following template expression

4516fa8

a-tarasyuk force-pushed the fix/47597 branch from e1bf7cf to 4516fa8 Compare March 11, 2022 18:45

a-tarasyuk requested a review from DanielRosenwasser March 11, 2022 18:46

DanielRosenwasser approved these changes Mar 11, 2022

View reviewed changes

typescript-bot mentioned this pull request Mar 11, 2022

🤖 Pick PR #47657 (fix(47597): preProcessFile incorrec...) into release-4.6 #48223

Merged

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 11, 2022

Cherry-pick PR microsoft#47657 into release-4.6

09eb974

Component commits: 4516fa8 fix(47597): ignore commented imports following template expression

andrewbranch approved these changes Mar 15, 2022

View reviewed changes

andrewbranch merged commit c981c9b into microsoft:main Mar 15, 2022

DanielRosenwasser pushed a commit that referenced this pull request Mar 16, 2022

Cherry-pick PR #47657 into release-4.6 (#48223)

cfdef9d

Component commits: 4516fa8 fix(47597): ignore commented imports following template expression Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(47597): preProcessFile incorrectly identifies imports in comments after a template literal type#47657

fix(47597): preProcessFile incorrectly identifies imports in comments after a template literal type#47657
andrewbranch merged 1 commit intomicrosoft:mainfrom
a-tarasyuk:fix/47597

a-tarasyuk commented Jan 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielRosenwasser commented Mar 11, 2022

Uh oh!

typescript-bot commented Mar 11, 2022 •

edited

Loading

Uh oh!

DanielRosenwasser commented Mar 11, 2022

Uh oh!

typescript-bot commented Mar 11, 2022 •

edited

Loading

Uh oh!

typescript-bot commented Mar 11, 2022

Uh oh!

typescript-bot commented Mar 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

a-tarasyuk commented Jan 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielRosenwasser commented Mar 11, 2022

Uh oh!

typescript-bot commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Mar 11, 2022

Uh oh!

typescript-bot commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 11, 2022

Uh oh!

typescript-bot commented Mar 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Mar 11, 2022 •

edited

Loading

typescript-bot commented Mar 11, 2022 •

edited

Loading