Repository navigation
readline: add stricter validation for functions called after closed - #57680
Closed
dario-piotrowicz wants to merge 12 commits into
Closed
dario-piotrowicz wants to merge 12 commits into
dario-piotrowicz wants to merge 12 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57678
This PR makes it so that calling
pause(),resume()orwrite()on a closed readline interface results inERR_USE_AFTER_CLOSEerrors being thrown (following the same behavior asquestion())Note
I'm slightly concerned regarding the tests I needed to update, as those might indicate that the stricted
readline checks might have some potential unwanted implications, if the changes here were to land it might be
safer to add them as a semver major I think 🤔