Skip to content

bpo-35306: Handle '*' in pathlib.Path functions on Windows - #11133

Closed
vladima wants to merge 2 commits into
python:masterfrom
vladima:pathlib
Closed

bpo-35306: Handle '*' in pathlib.Path functions on Windows#11133
vladima wants to merge 2 commits into
python:masterfrom
vladima:pathlib

Conversation

@vladima

@vladima vladima commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

Added EINVAL to the set of ignored errors as suggested in comment.

https://bugs.python.org/issue35306

@vladima

vladima commented Dec 14, 2018

Copy link
Copy Markdown
Contributor Author

@eryksun this is what was proposed in a discussion, can you please take a look?

@vladima

vladima commented Dec 25, 2018

Copy link
Copy Markdown
Contributor Author

@eryksun can you please tell if there is anything else that needs to be done here?

@vladima

vladima commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

is there anything else that should be done for this PR?

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me after a rebase, though @pitrou may want to have a look.

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @vladima Would you like to rebase / merge from master a last time and fix conflicts?

@zooba

zooba commented Apr 22, 2021

Copy link
Copy Markdown
Member

Apologies for not seeing this before I did my own patch :( It's fixed now

Thanks for submitting the PR anyway!

@zooba zooba closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants