When compiling without a specified --edition, emit a note - #158102
Open
estebank wants to merge 4 commits into
Open
When compiling without a specified --edition, emit a note#158102estebank wants to merge 4 commits into
--edition, emit a note#158102estebank wants to merge 4 commits into
Conversation
rustbot
added
A-compiletest
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I'll try to write an MCP later (unless someone does it for me). This change was motivated after seeing https://internals.rust-lang.org/t/code-compiles-on-playground-but-fails-when-passed-via-stdin-to-rustc/24393 where the different defaults between cargo, playground and rustc caused people to get confused. |
estebank
force-pushed
the
note-default-edition
branch
from
June 18, 2026 20:41
b923a75 to
2a486d3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
note-default-edition
branch
from
July 21, 2026 02:17
4241536 to
d71c2fa
Compare
3 tasks
estebank
added
the
S-blocked
estebank
marked this pull request as ready for review
July 21, 2026 02:25
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
jieyouxu
removed
the
S-waiting-on-review
estebank
force-pushed
the
note-default-edition
branch
from
July 27, 2026 06:56
d71c2fa to
a1d6de2
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
estebank
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.