Emit thumb code on VEX V5 - #158762
Open
lewisfm wants to merge 2 commits into
Open
Conversation
Collaborator
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb These commits modify compiler targets. |
Collaborator
|
r? @Kivooeo rustbot has assigned @Kivooeo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Gavin-Niederman
approved these changes
Jul 4, 2026
tropicaaal
reviewed
Jul 11, 2026
|
|
||
| **Tier: 3** | ||
|
|
||
| Allows compiling user programs for the [VEX V5 Brain](https://www.vexrobotics.com/276-4810.html), a microcontroller for educational and competitive robotics. | ||
|
|
||
| Rust support for this target is not affiliated with VEX Robotics or IFI, and does not link against any official VEX SDK. | ||
|
|
||
| This target was previously named `armv7a-vex-v5`. |
Contributor
There was a problem hiding this comment.
Not a blocker, but it might be a good idea for this to be elaborated on wrt. why we changed to thumb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the default codegen for the VEX V5 target to emit Thumb-2 instructions, allowing for smaller binary sizes (on the programs I tested this change on, I saw a ~20% size decrease on average). The target is renamed to have the
thumbprefix instead of thearmprefix because of the updated instruction set.Since VEXos starts all programs in Arm32 mode, the program entrypoint is explicitly compiled as ARM code and now transitions to Thumb mode when calling
_start.Users can still use the updated target in Arm32 mode by specifying
-Ctarget-feature=-thumb-mode.cc @tropicaaal @Gavin-Niederman