Skip to content

Add regression tests for a number of ICEs and diagnostics issues labelled E-needs-test - #160407

Open
jakubadamw wants to merge 7 commits into
rust-lang:mainfrom
jakubadamw:e-needs-test
Open

Add regression tests for a number of ICEs and diagnostics issues labelled E-needs-test#160407
jakubadamw wants to merge 7 commits into
rust-lang:mainfrom
jakubadamw:e-needs-test

Conversation

@jakubadamw

@jakubadamw jakubadamw commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

These have since been fixed and need tests.

Closing #111411.
Closing #114665.
Closing #118478.
Closing #122214.
Closing #129372.
Closing #138891.
Closing #141400.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 2, 2026
@rustbot

rustbot commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@@ -0,0 +1,9 @@
//! Regression test for https://github.com/rust-lang/rust/issues/114665.
//@ check-pass

@nnethercote nnethercote Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs build-pass because the bug happened during code generation.

View changes since the review

@@ -0,0 +1,20 @@
//! Regression test for https://github.com/rust-lang/rust/issues/122214.

@nnethercote nnethercote Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this one need to be in tests/incremental? Does it trigger the ICE in the old nightly when it's in tests/ui?

View changes since the review

@nnethercote nnethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants