Skip to content

move mir-opt miri tests to CI logic - #160422

Open
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:miri-mir-opt-tests
Open

move mir-opt miri tests to CI logic#160422
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:miri-mir-opt-tests

Conversation

@RalfJung

@RalfJung RalfJung commented Aug 3, 2026

Copy link
Copy Markdown
Member

It is useful to run Miri tests with mir-opts as that sometimes finds miscompilations.

However, doing so on every ./x test miri is annoying as it makes that take a lot longer, and it is inconsistent with ./miri test in the Miri repo. So remove this logic there, and instead have the check-miri script in CI invoke the test suite a 2nd time with mir-opts enabled.

Cc @rust-lang/miri

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 3, 2026
@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants