avoid using core_intrinsics feature (for a transition) - #1500
Closed
RalfJung wants to merge 1 commit into
Closed
Conversation
Collaborator
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
RalfJung
force-pushed
the
no-core-intrinsics
branch
from
November 21, 2023 07:29
d265a4b to
6b0d0b0
Compare
RalfJung
force-pushed
the
no-core-intrinsics
branch
from
November 21, 2023 07:31
6b0d0b0 to
8ff7918
Compare
Member
Author
|
Hm, that test failure looks unrelated to my change? |
Contributor
|
It can be a qemu glitch. |
Member
|
I restarted the tests, but I think it might be a real failure. Perhaps something got updated on the LLVM side and it now generates a different instruction? |
Member
Author
|
Renaming this feature is a big hassle, so I've changed the rustc PR to avoid doing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should let us do the transition in rust-lang/rust#118123.