[6.x] Fix required validation on empty code fields - #14918
Merged
Conversation
Validate against the code string rather than the wrapping object so `required` fails when a code field is left empty. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
duncanmcclean
added a commit
to mefenlon/cookie-notice
that referenced
this pull request
Jul 8, 2026
The Code fieldtype now passes the plain code string to validation rules, rather than an array (statamic/cms#14918). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where setting a
codefieldtype torequiredhad no effect — an empty field would pass validation and the entry would save.This was happening because the code fieldtype submits an object (
{ code: null, mode: '...' }) rather than a scalar. Since that object is a non-empty array, Laravel'srequiredrule considered it present and passed.This PR fixes it by adding a
preProcessValidatablemethod to the fieldtype, which unwraps the object so validation rules run against the code string itself. When the field is empty,requirednow correctly fails.Fixes #14907