[6.x] Fix Control Panel not scrolling to top on navigation - #14965
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the Control Panel wouldn't scroll back to the top when navigating between pages — after scrolling down a tall page, the next page would open scrolled down (clamped to its max scroll height) instead of at the top.
This was happening because the CP's real scroll container is
#main-content— the window itself never scrolls. Inertia's scroll reset only acts on the window and elements marked with thescroll-regionattribute, so it had nothing to reset and the previous scroll position persisted across navigations.This PR fixes it by marking
#main-contentas ascroll-region, so Inertia now resets its scroll position on navigation and also restores it natively when navigating back/forward through browser history.Fixes #14954