feat(Port): pass highlightColor from pinAttributes to pcb_port - #1838
Closed
bimakw wants to merge 1 commit into
Closed
feat(Port): pass highlightColor from pinAttributes to pcb_port#1838bimakw wants to merge 1 commit into
bimakw wants to merge 1 commit into
Conversation
- Add _getPinoutHighlightColor() method to read highlightColor from pinAttributes - Include highlight_color in pcb_port data during initial and update renders - Enables colored labels in pinout diagrams via pinAttributes configuration
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@seveibar @imrishabh18 - This PR is ready for review. CI is passing. This implements the |
This was referenced Jan 17, 2026
Contributor
Author
|
Hey @seveibar, this PR has been approved by @rushabhcodes and all CI checks are passing. Ready for merge when you have a moment! 🙏 |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the
highlightColorfeature for pinout diagrams by passing the color value frompinAttributestopcb_port:_getPinoutHighlightColor()method: ReadshighlightColorfrompinAttributesconfigurationhighlight_colorin pcb_port: Pass the color value during both initial and update rendersTest Plan
chip-board-pinout.test.tspassesRelated
Usage Example