Stabilize synchronous gauge - #6419
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
============================================
- Coverage 90.92% 90.90% -0.02%
- Complexity 6165 6167 +2
============================================
Files 678 678
Lines 18453 18484 +31
Branches 1812 1813 +1
============================================
+ Hits 16778 16803 +25
- Misses 1141 1146 +5
- Partials 534 535 +1 ☔ View full report in Codecov by Sentry. |
laurit
approved these changes
May 6, 2024
trask
approved these changes
May 8, 2024
| /** | ||
| * Builds and returns a DoubleGauge instrument with the configuration. | ||
| * | ||
| * <p>NOTE: This produces a synchronous gauge which records gauge values as they occur. Most users |
Member
There was a problem hiding this comment.
Maybe something about how only the most recent one is exported, since I think that part of synchronous gauges is most likely to trip people up?
Member
Author
There was a problem hiding this comment.
I'll add a comment to that effect.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronous gauges are now stable in the spec: open-telemetry/opentelemetry-specification#4019
Resolves #5795.