Delete multiple events at once#81

Mike-Hermans · 2022-06-02T12:43:56Z

Fixes #39 by making the command more consistent with the wp cron event run command.

It is now possible to delete multiple cron events at once by either:

Specifying multiple hooks that need to be deleted:

$ wp cron event delete wp_version_check wp_update_plugins

Delete all cron events that are due now

$ wp cron event delete --due-now

Delete all cron events at once

$ wp cron event delete --all

Since the selection process of the run and delete command is now the same, a separate function has been added to filter the required hooks (::get_selected_cron_events()).

General improvements to the build process

Escape prefix when listing all tables with prefix

Display correct error when plugin update fails to update plugins

``` Loading composer repositories with package information Updating dependencies (including require-dev) - Removing symfony/finder (v2.8.16) - Installing symfony/finder (v2.8.17) Loading from cache - Removing symfony/yaml (v2.8.16) - Installing symfony/yaml (v2.8.17) Downloading: 100% - Removing symfony/filesystem (v2.8.16) - Installing symfony/filesystem (v2.8.17) Loading from cache - Removing symfony/config (v2.8.16) - Installing symfony/config (v2.8.17) Downloading: 100% - Removing symfony/debug (v2.8.16) - Installing symfony/debug (v2.8.17) Downloading: 100% - Removing symfony/console (v2.8.16) - Installing symfony/console (v2.8.17) Downloading: 100% - Removing symfony/dependency-injection (v2.8.16) - Installing symfony/dependency-injection (v2.8.17) Downloading: 100% - Removing symfony/event-dispatcher (v2.8.16) - Installing symfony/event-dispatcher (v2.8.17) Loading from cache - Removing symfony/process (v2.8.16) - Installing symfony/process (v2.8.17) Downloading: 100% - Removing symfony/translation (v2.8.16) - Installing symfony/translation (v2.8.17) Downloading: 100% - Removing wp-cli/php-cli-tools (v0.11.1) - Installing wp-cli/php-cli-tools (v0.11.2) Downloading: 100% Writing lock file Generating autoload files ```

Update Composer dependencies (2/15/2017)

Uses the snippet from the Travis CI Docs found here: [https://docs.travis-ci.com/user/languages/php#Disabling-preinstalled-PHP-extensions](https://docs.travis-ci.com/user/languages/php#Disabling-preinstalled-PHP-extensions) Fixes #3812

Remove XDebug from PHP runtime within Travis CI environment.

Cache Composer in scaffolded plugin `.travis.yml`

Issues 3817 Existing PDF previews not deleted on media regenerate.

By default, disable auto-commit and (unique and forefin) key checks. Introduce skip-optimization flag to force old behavior.

This reverts commit 7c8dbb9.

janw-me

I like the refactor.
The tests need a bit more work.

features/cron.feature

README.md

features/cron.feature

danielbachhuber · 2022-07-28T15:27:30Z

@Mike-Hermans @janw-me How's this pull request coming along? Anything I can help with?

Mike-Hermans · 2022-08-08T07:57:33Z

Hi @danielbachhuber

I was waiting on a response from @janw-me on the cron.feature test from the conversation above, and a new review based on the changes made.

janw-me · 2022-08-11T15:14:02Z

Sorry, I didn't see the notification.
The last comment was just to check.
@Mike-Hermans his conformation was all we need.

schlessera · 2022-08-11T15:28:04Z

src/Cron_Event_Command.php

+		if ( empty( $args ) && ! Utils\get_flag_value( $assoc_args, 'due-now' ) && ! Utils\get_flag_value( $assoc_args, 'all' ) ) {
+			WP_CLI::error( 'Please specify one or more cron events, or use --due-now/--all.' );
+		}


This also needs safeguards for flag combinations that don't make sense.

If you provide hooks, the addition of --due-now or --all should throw an error.

Providing both --due-now and --all at the same time should throw an error.

Note: these should also have there seperate test cases.

Yes, you are right. I will fix this soon.

Hi @schlessera

After seeing other tests break I realized it should be possible to select hooks and combine them with the --due-now parameter. Only hooks + --all and --due-now --all should be invalid.

src/Cron_Event_Command.php

Mike-Hermans · 2022-09-16T09:45:06Z

Hi @schlessera

I've updated the code and tests. Hooks are now valid in combination with --due-now, as this was already possible on the 'run' command as well.

danielbachhuber · 2022-11-18T15:37:01Z

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/09504e7a7cdb1144c2e6162950d2f594 in case this PR is auto-closed or broken in some way.

danielbachhuber and others added 30 commits February 7, 2017 11:19

Remove code that exposes private key

0653ac3

Revert debugging comments

f985ef3

DEPLOY_BRANCH needs to be 'master'

bd0d8cb

Merge pull request #3799 from wp-cli/test-improvements

509732c

General improvements to the build process

Failing test case for #3794

3ff6abf

Escape prefix when listing all tables with prefix

85a5125

Assign a new variable, so later use of $prefix isn't clobbered

97030bb

Merge pull request #3801 from wp-cli/3794-escape-prefix

05306fe

Escape prefix when listing all tables with prefix

fixed bug #3790

24aec1d

added to check stderr

5de154c

to be same with another ommand

d111487

add tests for one or more plugin is updated

add391a

Merge pull request #3803 from miya0001/bug-fix-on-plugin-update

d319bf0

Display correct error when plugin update fails to update plugins

Merge pull request #3809 from wp-cli/update-deps-2017-02-15

827fb70

Update Composer dependencies (2/15/2017)

Merge pull request #3813 from schlessera/3812-disable-xdebug-in-travis

f900a4b

Remove XDebug from PHP runtime within Travis CI environment.

Cache Composer in scaffolded plugin .travis.yml

01bdf7b

Merge pull request #3816 from wp-cli/cache-composer

b8c50b8

Cache Composer in scaffolded plugin `.travis.yml`

dont attempt to rename ZIPs being installed from raw github sources

2001084

Fix existing PDF previews not deleted on media regenerate.

e7c187b

Check only_missing branch as well (fold PDF tests into existing ones).

97541ab

Remove somehow duplicated test.

171d9b9

Replace localhost with wp-cli.org.

a6a1686

Split out PDF tests as they require WP >= 4.7.1.

ceb0f3b

Merge pull request #3824 from gitlost/issues_3817

6ef1ca2

Issues 3817 Existing PDF previews not deleted on media regenerate.

Improve DB import. #3820

3f0ba39

By default, disable auto-commit and (unique and forefin) key checks. Introduce skip-optimization flag to force old behavior.

partial fix wp-cli/wp-cli#3832

f2f8f46

partial fix wp-cli/wp-cli#3832

423322e

partial fix wp-cli/wp-cli#3832

3bd7581

Mike-Hermans changed the title ~~Delete multiple events~~ Delete multiple events at once Jun 2, 2022

Mike-Hermans added 10 commits June 2, 2022 15:16

Combine selecting cron jobs functionality into a separate function

8856522

Move delete function to group with run and unschedule

7c8dbb9

Revert "Move delete function to group with run and unschedule"

b9a9040

This reverts commit 7c8dbb9.

Remove accidental newline

fb69c2a

Update README

3c29e28

Create function to get selected cron events

765f4ea

Implement get_selected_cron_events function in unschedule command

c298331

Undo changes for unschedule command

439e0f6

Update README

4fe77f9

Undo changes to composer.json

3dc309f

janw-me requested changes Jun 6, 2022

View reviewed changes

features/cron.feature Show resolved Hide resolved

README.md Show resolved Hide resolved

features/cron.feature Show resolved Hide resolved

Update tests and change delete output on 0 deletions

9688e89

janw-me approved these changes Aug 11, 2022

View reviewed changes

schlessera requested changes Aug 11, 2022

View reviewed changes

danielbachhuber added command:cron command:cron-event-delete labels Aug 11, 2022

Mike-Hermans added 5 commits September 11, 2022 15:53

More compact message on delete command

40e4ad1

Allow only a valid combination of parameters

977186f

Remove call_user_func

884dc1f

PHPCS and update tests

85ea5f9

Update test and allow hooks in combination with --due-all

fca90c6

danielbachhuber closed this Nov 18, 2022

danielbachhuber force-pushed the master branch from 406abbd to 20e7367 Compare November 18, 2022 15:52

Mike-Hermans mentioned this pull request Jun 8, 2023

Add --all flag to cron event delete #98

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete multiple events at once#81

Delete multiple events at once#81
Mike-Hermans wants to merge 7338 commits intowp-cli:masterfrom
Mike-Hermans:39-add-all-flag-to-delete

Mike-Hermans commented Jun 2, 2022 •

edited

Loading

Uh oh!

janw-me left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielbachhuber commented Jul 28, 2022

Uh oh!

Mike-Hermans commented Aug 8, 2022

Uh oh!

janw-me commented Aug 11, 2022

Uh oh!

schlessera Aug 11, 2022

Uh oh!

schlessera Aug 11, 2022

Uh oh!

Mike-Hermans Sep 5, 2022

Uh oh!

Mike-Hermans Sep 16, 2022

Uh oh!

Uh oh!

Uh oh!

Mike-Hermans commented Sep 16, 2022

Uh oh!

danielbachhuber commented Nov 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

Mike-Hermans commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janw-me left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielbachhuber commented Jul 28, 2022

Uh oh!

Mike-Hermans commented Aug 8, 2022

Uh oh!

janw-me commented Aug 11, 2022

Uh oh!

schlessera Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

schlessera Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

Mike-Hermans Sep 5, 2022

Choose a reason for hiding this comment

Uh oh!

Mike-Hermans Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mike-Hermans commented Sep 16, 2022

Uh oh!

danielbachhuber commented Nov 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Mike-Hermans commented Jun 2, 2022 •

edited

Loading