-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix dynamic parameter completion #19510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic parameter completion #19510
Conversation
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
PR Summary
Fixes the following scenario:
Where tab completion wouldn't show the filesystem provider dynamic parameters, such as "-File".
The reason for this is that it tries to bind the parameters typed so far, including the partially typed parameter which wouldn't work. A check has been added so the parameter at the cursor is skipped for commands with dynamic parameters.
PR Context
Fixes #19498
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).