➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-04-05 22:29 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 1011 | open | serhiy.storchaka, 2017-04-05 22:30 | |
| PR 11580 | remi.lapeyre, 2019-01-30 16:00 | ||
| Messages (5) | |||
|---|---|---|---|
| msg291200 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2017-04-05 22:29 | |
The repr of standard exceptions usually looks as exception constructor used for creating that exception. But the repr of ImportError misses keyword arguments name and path.
>>> ImportError('test', name='somename', path='somepath')
ImportError('test',)
Proposed patch make the repr of ImportError containing keyword arguments.
>>> ImportError('test', name='somename', path='somepath')
ImportError('test', name='somename', path='somepath')
I don't know how to classify this issue and whether the patch should be backported.
|
|||
| msg291241 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2017-04-06 17:56 | |
I consider it an enhancement, especially if someone was slopping with their tests and explicitly checks the repr of ImportError. |
|||
| msg291633 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-04-13 21:24 | |
The patch also changes the repr of BaseException with a single argument. It no longer contains a trailing comma. |
|||
| msg292205 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-04-24 08:35 | |
Including 'path' may make the repr less readable in some cases. +1 for 'name', though. |
|||
| msg334569 - (view) | Author: Rémi Lapeyre (remi.lapeyre) * | Date: 2019-01-30 16:00 | |
I think the issue steems from the more general #27015 for which a PR is ready that fixes the repr not only for ImportError but all other BaseException subclasses that override __init__. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:45 | admin | set | github: 74185 |
| 2019-01-30 16:00:33 | remi.lapeyre | set | nosy:
+ remi.lapeyre messages: + msg334569 pull_requests: + pull_request11554 keywords: + patch |
| 2017-04-24 08:35:04 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg292205 |
| 2017-04-13 21:24:25 | serhiy.storchaka | set | assignee: serhiy.storchaka messages: + msg291633 |
| 2017-04-06 17:56:01 | brett.cannon | set | type: enhancement messages: + msg291241 |
| 2017-04-05 22:30:49 | serhiy.storchaka | set | pull_requests: + pull_request1179 |
| 2017-04-05 22:29:11 | serhiy.storchaka | create | |
