Consider <html> a block-level HTML element #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
force-pushed
the
fix-html-block-tag
branch
from
d6018cd to
85c3c11
Compare
Contributor
Author
|
FTR, some older third parties seem to use |
Collaborator
We can't really control how people monkey patch the lib. Once you start monkey patching like they do, you are on your own. |
waylan
approved these changes
Dec 1, 2022
waylan
requested changes
Dec 1, 2022
Member
waylan
left a comment
waylan
left a comment
There was a problem hiding this comment.
We need to add a comment to the changelog indicating that the list of block-level-elements was changed.
kernc
force-pushed
the
fix-html-block-tag
branch
from
85c3c11 to
1575d1c
Compare
facelessuser
approved these changes
Dec 1, 2022
waylan
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1308
I'm obviously :+1: on adding
<html>to block-level elements. Literal HTML is valid syntax in markdown, and the specification forDocumentFragmentdoesn't mention any limits wrt what particular nodes the fragment is or isn't allowed to consist of ...