Skip to content

[py][bidi]: enable download event tests for firefox #16587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navin772 merged 2 commits into from
Nov 13, 2025
Merged

[py][bidi]: enable download event tests for firefox #16587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e98cd
enable tests for firefox
navin772 Nov 12, 2025
5ca7c96
Merge branch 'trunk' into py-enable-download-event-tests-ff
navin772 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions py/test/selenium/webdriver/common/bidi_browsing_context_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,6 @@ def on_history_updated(info):
driver.browsing_context.remove_event_handler("history_updated", callback_id)


@pytest.mark.xfail_firefox
def test_add_event_handler_download_will_begin(driver, pages):
"""Test adding event handler for download_will_begin event."""
events_received = []
Expand All @@ -802,12 +801,12 @@ def on_download_will_begin(info):
WebDriverWait(driver, 5).until(lambda d: len(events_received) > 0)

assert len(events_received) == 1
assert events_received[0].suggested_filename == "file_1.txt"
# filename maybe file_1.txt or file_1(1).txt depending on existing files in download dir
assert "file_1" in events_received[0].suggested_filename

driver.browsing_context.remove_event_handler("download_will_begin", callback_id)


@pytest.mark.xfail_firefox
def test_add_event_handler_download_end(driver, pages):
"""Test adding event handler for download_end event."""
events_received = []
Expand Down