Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 47e1019efd
Choose a base ref
...
head repository: git/git
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a446f2dcc8
Choose a head ref
  • 15 commits
  • 67 files changed
  • 2 contributors

Commits on Feb 22, 2019

  1. trace2: Documentation/technical/api-trace2.txt 

    Created design document for Trace2 feature.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    e544221 View commit details
    Browse the repository at this point in the history

  2. trace2: create new combined trace facility 

    Create a new unified tracing facility for git.  The eventual intent is to
replace the current trace_printf* and trace_performance* routines with a
unified set of git_trace2* routines.

In addition to the usual printf-style API, trace2 provides higer-level
event verbs with fixed-fields allowing structured data to be written.
This makes post-processing and analysis easier for external tools.

Trace2 defines 3 output targets.  These are set using the environment
variables "GIT_TR2", "GIT_TR2_PERF", and "GIT_TR2_EVENT".  These may be
set to "1" or to an absolute pathname (just like the current GIT_TRACE).

* GIT_TR2 is intended to be a replacement for GIT_TRACE and logs command
  summary data.

* GIT_TR2_PERF is intended as a replacement for GIT_TRACE_PERFORMANCE.
  It extends the output with columns for the command process, thread,
  repo, absolute and relative elapsed times.  It reports events for
  child process start/stop, thread start/stop, and per-thread function
  nesting.

* GIT_TR2_EVENT is a new structured format. It writes event data as a
  series of JSON records.

Calls to trace2 functions log to any of the 3 output targets enabled
without the need to call different trace_printf* or trace_performance*
routines.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    ee4512e View commit details
    Browse the repository at this point in the history

  3. trace2: collect Windows-specific process information 

    Add platform-specific interface to log information about the current
process.

On Windows, this interface is used to indicate whether the git process
is running under a debugger and list names of the process ancestors.

Information for other platforms is left for a future effort.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    353d3d7 View commit details
    Browse the repository at this point in the history

  4. trace2:data: add trace2 regions to wt-status 

    Add trace2_region_enter() and trace2_region_leave() calls around the
various phases of a status scan.  This gives elapsed time for each
phase in the GIT_TR2_PERF and GIT_TR2_EVENT trace target.

Also, these Trace2 calls now use s->repo rather than the_repository.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    942b274 View commit details
    Browse the repository at this point in the history

  5. trace2:data: add editor/pager child classification 

    Add trace2 process classification for editor and pager
child processes.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    eee73d1 View commit details
    Browse the repository at this point in the history

  6. trace2:data: add trace2 sub-process classification 

    Add trace2 classification for long-running processes
started in sub-process.c

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    0671b4d View commit details
    Browse the repository at this point in the history

  7. trace2:data: add trace2 transport child classification 

    Add trace2 child classification for transport processes.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    abd81a3 View commit details
    Browse the repository at this point in the history

  8. trace2:data: add trace2 hook classification 

    Classify certain child processes as hooks.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    6206286 View commit details
    Browse the repository at this point in the history

  9. trace2:data: add trace2 instrumentation to index read/write 

    Add trace2 events to measure reading and writing the index.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    42fee7a View commit details
    Browse the repository at this point in the history

  10. trace2:data: pack-objects: add trace2 regions 

    When studying the performance of 'git push' we would like to know
how much time is spent at various parts of the command. One area
that could cause performance trouble is 'git pack-objects'.

Add trace2 regions around the three main actions taken in this
command:

1. Enumerate objects.
2. Prepare pack.
3. Write pack-file.

Signed-off-by: Derrick Stolee <[email protected]>
Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @derrickstolee @gitster
    derrickstolee authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    ae41780 View commit details
    Browse the repository at this point in the history

  11. trace2:data: add subverb to checkout command 

    Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    e27dd8a View commit details
    Browse the repository at this point in the history

  12. trace2:data: add subverb to reset command 

    Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    c18b6c1 View commit details
    Browse the repository at this point in the history

  13. trace2:data: add subverb for rebase 

    Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    b3a5d5a View commit details
    Browse the repository at this point in the history

  14. trace2: t/helper/test-trace2, t0210.sh, t0211.sh, t0212.sh 

    Create unit tests for Trace2.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    a15860d View commit details
    Browse the repository at this point in the history

  15. trace2: add for_each macros to clang-format 

    Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @jeffhostetler @gitster
    jeffhostetler authored and gitster committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    a446f2d View commit details
    Browse the repository at this point in the history
Loading