gh-106145: Make end_{lineno,col_offset} required on type_param nodes (#106224)

sobolevn · web-flow · commit 46c109786874 · 2023-06-30T23:45:08.000Z
diff --git a/Lib/test/test_unparse.py b/Lib/test/test_unparse.py
@@ -705,7 +705,7 @@ class DirectoryTestCase(ASTTestCase):
     test_directories = (lib_dir, lib_dir / "test")
     run_always_files = {"test_grammar.py", "test_syntax.py", "test_compile.py",
                         "test_ast.py", "test_asdl_parser.py", "test_fstring.py",
-                        "test_patma.py"}
+                        "test_patma.py", "test_type_alias.py", "test_type_params.py"}
 
     _files_to_test = None
 
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-06-29-09-46-41.gh-issue-106145.QC6-Kq.rst b/Misc/NEWS.d/next/Core and Builtins/2023-06-29-09-46-41.gh-issue-106145.QC6-Kq.rst
@@ -0,0 +1,2 @@
+Make ``end_lineno`` and ``end_col_offset`` required on ``type_param`` ast
+nodes.
diff --git a/Parser/Python.asdl b/Parser/Python.asdl
@@ -148,5 +148,5 @@ module Python
     type_param = TypeVar(identifier name, expr? bound)
                | ParamSpec(identifier name)
                | TypeVarTuple(identifier name)
-               attributes (int lineno, int col_offset, int? end_lineno, int? end_col_offset)
+               attributes (int lineno, int col_offset, int end_lineno, int end_col_offset)
 }
diff --git a/Python/Python-ast.c b/Python/Python-ast.c

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Make ``end_lineno`` and ``end_col_offset`` required on ``type_param`` ast
	`2`	`+nodes.`
Original file line number	Diff line number	Diff line change
`@@ -148,5 +148,5 @@ module Python`
`148`	`148`	`type_param = TypeVar(identifier name, expr? bound)`
`149`	`149`	`\| ParamSpec(identifier name)`
`150`	`150`	`\| TypeVarTuple(identifier name)`
`151`		`- attributes (int lineno, int col_offset, int? end_lineno, int? end_col_offset)`
	`151`	`+ attributes (int lineno, int col_offset, int end_lineno, int end_col_offset)`
`152`	`152`	`}`