gh-142433: Move deref to below the error when checking for laststring #142402
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
AZero13
force-pushed
the
deref-template
branch
from
cd23b28 to
f476012
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@AZero13 Can you write a news entry and create a corresponding issue? See https://devguide.python.org/getting-started/pull-request-lifecycle/ for details |
AZero13
force-pushed
the
deref-template
branch
from
f476012 to
18adb8c
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
AZero13
changed the title
AZero13
force-pushed
the
deref-template
branch
from
18adb8c to
d101bfc
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
AZero13
force-pushed
the
deref-template
branch
from
d101bfc to
52639d7
Compare
AZero13
changed the title
AZero13
force-pushed
the
deref-template
branch
from
52639d7 to
8714926
Compare
…string Move deref of laststring to below the error checking so the deref is applied after the object in strings is replaced.
AZero13
force-pushed
the
deref-template
branch
from
8714926 to
47557b9
Compare
|
@AZero13 please avoid force pushes, it makes reviewing harder |
eendebakpt
left a comment
eendebakpt
left a comment
There was a problem hiding this comment.
The news entry needs a bit of work, but the change to the code looks good.
Misc/NEWS.d/next/Core_and_Builtins/2025-12-08-17-34-57.gh-issue-142402.iV0ON3.rst
Outdated
Show resolved
Hide resolved
…string (pythonGH-142402) Move deref of laststring to below the error checking so the deref is applied after the object in strings is replaced. (cherry picked from commit 785268f) Co-authored-by: AZero13 <[email protected]>
|
GH-142524 is a backport of this pull request to the 3.14 branch. |
|
Merged, thanks. |
…tstring (GH-142402) (#142524) gh-142433: Move deref to below the error when checking for laststring (GH-142402) Move deref of laststring to below the error checking so the deref is applied after the object in strings is replaced. (cherry picked from commit 785268f) Co-authored-by: AZero13 <[email protected]>
4 participants
Move deref of laststring to below the error checking so the deref is applied after the object in strings is replaced.