Skip to content

GH-83162: Rename re.error for better clarity. #101676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
achhina wants to merge 1 commit into from
Closed

GH-83162: Rename re.error for better clarity. #101676

achhina wants to merge 1 commit into from

Conversation

@achhina
Copy link
Contributor

@achhina achhina commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Follow-up of rebased/squashed PR-1751 - renaming re.error for better clarity.

TODO

  • Settle on new exception name
  • Re-run tests
  • Follow-up on whether we rename the exception in idlelib/replace.py
  • Ask whether this should also be added Python 3.12 What's New

@bedevere-bot bedevere-bot mentioned this pull request Feb 8, 2023
Closed
@achhina achhina changed the title GH-83612: Rename re.error for better clarity. GH-83162: Rename re.error for better clarity. Feb 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 8, 2023
Closed
@achhina achhina closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy will be requested when the pull request is marked ready for review terryjreedy is a code owner

@ammaraskar ammaraskar Awaiting requested review from ammaraskar ammaraskar will be requested when the pull request is marked ready for review ammaraskar is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achhina @bedevere-bot