Skip to content

Conversation

@vcapparelli
Copy link

@vcapparelli vcapparelli commented May 3, 2023

@ghost
Copy link

ghost commented May 3, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@serhiy-storchaka
Copy link
Member

@bitdancer, please take a look, it is an implementation of your suggestion.

Note that quotechar only requires quoting if doublequote is true.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algorithm for quoting is more complex, for example empty strings and None can be quoted in some circumstances to avoid ambiguity. Accurate description of the algorithm would be too complex too, and have a risk of desynchronizing from the implementation.

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants