Skip to content

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 15, 2023

This fixes the segfault reported on the issue, it also avoids adding any new API as it has to be backported and is minimal.

@kumaraditya303 kumaraditya303 added type-crash A hard crash of the interpreter, possibly with a core dump 3.12 only security fixes 3.13 bugs and security fixes needs backport to 3.12 only security fixes extension-modules C modules in the Modules dir labels Nov 15, 2023
@Eclips4
Copy link
Member

Eclips4 commented Nov 15, 2023

With this patch I still getting segmentation fault:

./python.exe scratch.py
/Users/admin/Library/Application Support/JetBrains/CLion2023.2/scratches/scratch.py:12: DeprecationWarning: There is no current event loop
  asyncio.ensure_future(self._end_stream_wait())
zsh: segmentation fault  ./python.exe 

@erlend-aasland
Copy link
Contributor

Looks good to me. @Eclips4, did you do a clean build before testing this? (git clean -fdx)

@Eclips4
Copy link
Member

Eclips4 commented Nov 15, 2023

Looks good to me. @Eclips4, did you do a clean build before testing this? (git clean -fdx)

Yes.

@mgorny
Copy link
Contributor

mgorny commented Nov 19, 2023

I'm seeing the same segfault too, with my original reproducer. (I've applied this change on top of 3.12.0)

@Eclips4
Copy link
Member

Eclips4 commented Nov 19, 2023

I'm seeing the same segfault too, with my original reproducer. (I've applied this change on top of 3.12.0)

My week's research says that there's two possible segfaults. Soon I'll try to summarize what's actually happening.

@Eclips4
Copy link
Member

Eclips4 commented Dec 24, 2023

Closing it due to merge of #113405

@Eclips4 Eclips4 closed this Dec 24, 2023
@kumaraditya303 kumaraditya303 deleted the fix-xml branch June 23, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.12 only security fixes 3.13 bugs and security fixes awaiting core review extension-modules C modules in the Modules dir needs backport to 3.12 only security fixes type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants