gh-115225: Parsing fractions correctly in datetime.time.fromisoformat #115313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#115225 is regarding the incorrect behavior of
datetime.time.fromisoformat.@xitop points out in ISO8601 specified that a decimal fraction may be added to the lowest-order time element present. The OP also mentions that the current docs says fractional minutes/hours are not supported, and recommends to throw
ValueError.I found the current version had tried to parse fractional quantities somewhat but incorrectly, so I opted for including fractional time element and not raising an exception. Changed
Lib/_pydatetime.pyandModules/_datetimemodule.c. Alldatetimetests are ok.