Skip to content

gh-128231: Use runcode() return value for failing early (fix test) #131835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnslavik wants to merge 4 commits into from
Closed

gh-128231: Use runcode() return value for failing early (fix test) #131835

johnslavik wants to merge 4 commits into from

Conversation

@johnslavik
Copy link
Contributor

@johnslavik johnslavik commented Mar 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 28, 2025
Closed
@johnslavik johnslavik marked this pull request as ready for review March 28, 2025 12:29
@johnslavik
Copy link
Contributor Author

johnslavik commented Mar 28, 2025

OK, we'll do it a different way.

@johnslavik johnslavik closed this Mar 28, 2025
@johnslavik johnslavik deleted the make-prompts-fail-early-in-repl branch December 2, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

@willingc willingc Awaiting requested review from willingc

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@johnslavik