gh-134584: Eliminate redundant refcounting from _CALL_STR_1
#136070
Conversation
Signed-off-by: Manjusaka <[email protected]>
Zheaoli
requested review from
Fidget-Spinner,
markshannon and
tomasr8
as code owners
Signed-off-by: Manjusaka <[email protected]>
|
Thanks! This looks great to me. Just waiting for Mark's PR on TOS caching to get merged. |
| (void)callable; // Silence compiler warnings about unused variables | ||
| (void)null; | ||
| PyStackRef_CLOSE(arg); | ||
| a = arg; |
There was a problem hiding this comment.
Please move INPUTS_DEAD() to after this line (right before ERROR_IF).
Otherwise, LGTM, I will merge after this PR merges in main.
There was a problem hiding this comment.
I'm not sure my thought is right
The incorrect order will cause the incorrect stack_pointer movement right?
There was a problem hiding this comment.
Or it seems it's just a call convention(I have that the different order is not related with the generated code)
There was a problem hiding this comment.
I think I got it. In this case, seems INPUT_DEAD() is not related with the generated code. BTW we should keep the use the INPUT_DEAD after all input action completed to avoid generate wrong code in other ops
There was a problem hiding this comment.
Yeah the only problem is we need to move INPUTS_DEAD() to after ERROR_IF, but the code generator will reject it for now. So we need to wait till I merge my PR fixing that.
There was a problem hiding this comment.
You'll need to use ERROR_NO_POP() before modifying the stack.
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
3 participants
Uh oh!
There was an error while loading. Please reload this page.