-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-141004: Document soft-deprecated symbols #141634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-141004: Document soft-deprecated symbols #141634
Conversation
Yes. My opinion is that documentation for deprecated API should tell you what to do if you find it in some dusty legacy codebase. |
Ok, I can do that. I have a few ideas on how we could format this -- which do you prefer?
|
|
I'm not sure that a "Soft-deprecated" section is needed.
That sounds like a reasonable approach. |
I'd prefer “Deprecated API” sections at the end of pages. Alas, that might not be a popular preference :(
That makes sense for “close friends” -- e.g. if the porting instructions tell you to use a specific other function instead. |
If others are fine with a Deprecated API section, I would also be fine with it. |
|
See https://docs.python.org/3/c-api/unicode.html#deprecated-api for an example. I think it's working pretty well. |
It looks nice. |
|
Updated, let me know what you think.
In practice, we don't have great replacements for all of these, so I just documented some of them as "do not use". For example, what is a user supposed to do if they find |
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
|
Looks good! Hopefully the WG vote will be just a formality. |
These are all APIs that expose implementation details. Instead of truly documenting them and what they do, this PR just adds a note saying "don't use this" with no additional information. This is a good compromise for us; if someone saw these in their IDE, Python will still provide some form of documentation for them, but they won't lead to any additional maintenance burden.
cc @vstinner @encukou -- I suspect both of you will have some strong opinions here.
📚 Documentation preview 📚: https://cpython-previews--141634.org.readthedocs.build