-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
[3.13] gh-141004: Add a CI job ensuring that new C APIs include documentation (GH-142102) #142248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.13
Are you sure you want to change the base?
Conversation
…ntation (pythonGH-142102) Co-authored-by: Hugo van Kemenade <[email protected]> (cherry picked from commit 1a7824a)
… documentation (pythonGH-142102) (cherry picked from commit 1a7824a) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
See #142247 (comment). |
|
@hugovk Quick question -- it seems CI on 3.13 uses Python 3.12, not 3.13. Is that intentional? If so, I need to remove the use of |
|
Hmm, well we're installing However, for the 3.14 branch, when we run But on this 3.13 branch, for some reason we get: I'm not sure why configure is selecting 3.12... |
|
Do you know if the configure script on 3.13 checks for 3.14? I think that might be the problem. I'm guessing that Python 3.12 is already installed on the system the CI job is running on, and |
No, it only checks the current version and lower.
Line 3828 in 756e7d1
Line 3820 in f200776
Line 3765 in b57d695
Yes, that indeed looks like the problem. Here's a test workflow that installs a give version, then tries to check for them all: python3.15 --version --version || true
python3.14 --version --version || true
python3.13 --version --version || true
python3.12 --version --version || true
python3.11 --version --version || true
python3.10 --version --version || trueAnd they all have the given version, plus 3.12. For example with 3.15: And it's an old 3.12.3 baked into the image, because when we specifically ask for 3.12 we get the newest 3.12.12: |
|
Thanks, I created an issue: #142457 |
(cherry picked from commit 1a7824a)