Skip to content

bpo-24925: _find_lineno now finds doctest __test__ string line numbers #17553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jneb wants to merge 9 commits into from
Closed

bpo-24925: _find_lineno now finds doctest __test__ string line numbers #17553

jneb wants to merge 9 commits into from

Conversation

@jneb
Copy link
Contributor

@jneb jneb commented Dec 10, 2019 •
edited by bedevere-bot
Loading

If the doctest code is in a test string, _find_lineno now find the error, by looking for a line in the docstring that is unique in the source file.

https://bugs.python.org/issue24925

@jneb
bpo-24925: _find_lineno now finds doctest __test__ string line numbers
45e98a3 
If the doctest code is in a test string, _find_lineno now find the error, by looking for a line in the docstring that is unique in the source file.
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Dec 10, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jneb

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

jneb
jneb commented Dec 10, 2019
View reviewed changes
jneb added 2 commits December 10, 2019 14:45
@jneb
News file for patch 17553, issue 24925
5beb6a6 
I hope bedevere-bot likes me now.
@jneb
Merge pull request #2 from jneb/patch-2
be44d58 
News file for patch 17553, issue 24925
@jneb
Copy link
Contributor Author

jneb commented Dec 10, 2019 •
edited
Loading

I am having a bit of trouble getting my news file to work here.
(Edited: I think I did it correctly now.)

blurb-it bot and others added 4 commits December 13, 2019 12:32
@blurb-it
📜🤖 Added by blurb_it.
6dfefba
@jneb
Testing patch for __test__
d934e81 
Issue 24925 has a patch for finding line numbers in __test__ docstrings.
This code actually tests that.
@jneb
Aux file for doctest __test__ patch
cd252b1 
This file is used by test_doctest.
@jneb
Update doctest__test__.py
4098609 
Made it a bit more clear for posterity: now tells that you shouldn't edit the 'q' test.
@jneb
Copy link
Contributor Author

jneb commented Dec 13, 2019 •
edited
Loading

Yes, it is now actually tested and it works!
(Edited) ... after I fixed a typo. Oops.

@jneb
Fixed typo
ac9314c 
Just after I claimed it was fixed, I made a typo.
Anyway.
@jneb jneb closed this Jan 13, 2021
@jneb jneb deleted the patch-1 branch January 13, 2021 08:48
@bitdancer bitdancer mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jneb @the-knights-who-say-ni @bedevere-bot