bpo-39019: Implement missing __class_getitem__ for os.DirEntry #17561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
force-pushed
the
bpo-39019-3
branch
from
84839e7 to
3435737
Compare
ilevkivskyi
reviewed
Dec 27, 2019
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! Couple comments also here.
Misc/NEWS.d/next/Library/2019-12-10-21-22-20.bpo-39019.SkVoG0.rst
Outdated
Show resolved
Hide resolved
| OS_DIRENTRY_STAT_METHODDEF | ||
| OS_DIRENTRY_INODE_METHODDEF | ||
| OS_DIRENTRY___FSPATH___METHODDEF | ||
| {"__class_getitem__", DirEntry_cls_getitem, METH_O|METH_CLASS, NULL}, |
Member
There was a problem hiding this comment.
Would it be possible to use Argument Clinic for this (to be consistent with the rest of the code in this module)?
Member
Author
There was a problem hiding this comment.
I dont know if it possible, contextlib also uses argument clinic but they seperated __class_getitem. I thought there is a catch about this but I can try to do this with argument clinic.
Co-Authored-By: Ivan Levkivskyi <[email protected]>
Member
Author
|
Closing since pep 585 accepted |
Member
|
Hm, |
Member
Author
|
I was going to send a new PR but couldnt see it on PEP 585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39019