bpo-31803: Remove time.clock() #4018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove time.clock() function * time.get_clock_info() doesn't accept 'clock' anymore * Document the removal in What's New in Python 3.7 * Replace time.clock() with time.perf_counter() in the profile module, in turtledemo, and in ctypes tests.
This option wasn't implemented, documented, nor tested.
dianaclarke
reviewed
Oct 17, 2017
|
|
||
| .. versionadded:: 3.3 | ||
| .. versionchanged:: 3.7 | ||
| ``'clock'`` is no more accepted since ``time.clock()`` was removed. |
| ---- | ||
|
|
||
| The ``time.clock()`` function has been removed, it was deprecated since Python | ||
| 3.3. The function was not portable: on Windows it mesured wall-clock, whereas |
Member
There was a problem hiding this comment.
Perhaps replace:
it was deprecated since Python 3.3.
with:
as it has been deprecated since Python 3.3.
| ---- | ||
|
|
||
| The ``time.clock()`` function has been removed, it was deprecated since Python | ||
| 3.3. The function was not portable: on Windows it mesured wall-clock, whereas |
| The ``time.clock()`` function has been removed, it was deprecated since Python | ||
| 3.3. The function was not portable: on Windows it mesured wall-clock, whereas | ||
| it measured CPU time on Unix. Python provides better defined clocks with better | ||
| resolution since Python 3.3: use :func:`time.perf_counter` or |
Member
There was a problem hiding this comment.
Perhaps change:
Python provides better defined clocks with better resolution since Python 3.3
to:
Python has provided other clocks with better resolution since Python 3.3
Member
Author
|
I merged my PR #4020 which emits a deprecation warning. Let's wait for Pyhon 3.8 to remove time.clock(). I abandon this PR. |
Member
Author
|
Thanks for the review @dianaclarke anyway ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module, in turtledemo, and in ctypes tests.
https://bugs.python.org/issue31803