Skip to content

Use SupportsWrite instead of IO #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 8 commits into from
Mar 23, 2021
Merged

Use SupportsWrite instead of IO #5069

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f06f44
Split logging into Python 2 and 3 versions
srittau Feb 24, 2021
7761fdb
Remove unnecessary branches from logging
srittau Feb 24, 2021
3723b19
Use builtin collections for logging
srittau Feb 24, 2021
8d75f6f
Fixes
srittau Feb 24, 2021
187ea20
Work around mypy tuple bug
srittau Feb 24, 2021
e59d14e
Remove unused import
srittau Feb 24, 2021
0b604f5
Use SupportsWrite instead of IO
srittau Feb 24, 2021
fbad37f
Merge branch 'master' into stream-handler
JelleZijlstra Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions stdlib/logging/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sys
import threading
from _typeshed import StrPath
from _typeshed import StrPath, SupportsWrite
from collections.abc import Callable, Iterable, Mapping, MutableMapping, Sequence
from string import Template
from time import struct_time
Expand Down Expand Up @@ -673,7 +673,7 @@ if sys.version_info >= (3, 8):
datefmt: Optional[str] = ...,
style: str = ...,
level: Optional[_Level] = ...,
stream: Optional[IO[str]] = ...,
stream: Optional[SupportsWrite[str]] = ...,
handlers: Optional[Iterable[Handler]] = ...,
force: bool = ...,
) -> None: ...
Expand All @@ -687,7 +687,7 @@ else:
datefmt: Optional[str] = ...,
style: str = ...,
level: Optional[_Level] = ...,
stream: Optional[IO[str]] = ...,
stream: Optional[SupportsWrite[str]] = ...,
handlers: Optional[Iterable[Handler]] = ...,
) -> None: ...

Expand All @@ -699,11 +699,11 @@ def setLogRecordFactory(factory: Callable[..., LogRecord]) -> None: ...
lastResort: Optional[StreamHandler]

class StreamHandler(Handler):
stream: IO[str] # undocumented
stream: SupportsWrite[str] # undocumented
terminator: str
def __init__(self, stream: Optional[IO[str]] = ...) -> None: ...
def __init__(self, stream: Optional[SupportsWrite[str]] = ...) -> None: ...
if sys.version_info >= (3, 7):
def setStream(self, stream: IO[str]) -> Optional[IO[str]]: ...
def setStream(self, stream: SupportsWrite[str]) -> Optional[SupportsWrite[str]]: ...

class FileHandler(StreamHandler):
baseFilename: str # undocumented
Expand Down