Commit 2e6b641
committed
Refactor secrets manager approach for easier generalisability
This change has a potentially negative impact on the use of AWS Secrets Manager, in that it is no-longer possible to specify a different ARN or secret ID per account in the proxy's configuration file; instead, a command-line parameter (`--cache-store`) is introduced to specify a cache location (either an existing ARN or a new secret name (that must start with `aws_emailproxy@`)). However, there are several benefits to the new approach, including its generally simpler structure, and the fact that the cache location can now be redirected more easily to, for example, a local temporary file, or (with further development) any other secret management platform that can accept a JSON object.1 parent e11338d commit 2e6b641
File tree
4 files changed
+142
-146
lines changed4 files changed
+142
-146
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| 199 | + | |
| 200 | + | |
199 | 201 | | |
200 | 202 | | |
201 | 203 | | |
| |||
0 commit comments