Skip to content

Conversation

@nikitaTay
Copy link
Contributor

Changes for Embed Youtube Videos in different pages of grpc.io website-375352842 and its screenshots :
Screenshot 2024-11-07 7 28 20 PM
Screenshot 2024-11-07 7 30 46 PM
Screenshot 2024-11-07 7 31 32 PM
Screenshot 2024-11-07 7 32 06 PM
Screenshot 2024-11-07 7 32 48 PM
Screenshot 2024-11-07 7 33 22 PM
Screenshot 2024-11-07 7 34 32 PM
Screenshot 2024-11-07 7 35 03 PM
Screenshot 2024-11-07 7 35 32 PM
Screenshot 2024-11-07 7 36 06 PM

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2024

CLA Missing ID CLA Not Signed

@nikitaTay
Copy link
Contributor Author

Screenshot 2024-11-07 7 45 01 PM

@sreenithi sreenithi requested a review from temawi November 11, 2024 16:47
@sreenithi sreenithi changed the title Changes for EmbedVideos Embed YouTube videos in different webpages Nov 11, 2024
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please also do the EasyCLA thing.

@YifeiZhuang
Copy link
Member

LGTM! Thank you all.

@sreenithi sreenithi merged commit 196f408 into grpc:main Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants