Repository navigation
Fix: Add isNavigationBlock utility to identify navigation blocks - #68647
yogeshbhutkar wants to merge 1 commit into
Conversation
|
@yogeshbhutkar, as mentioned in the previous PR, it's better to create an issue and discuss possible solutions before moving on to code. I also don't think there's a need to introduce another public method just to check the block's name. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Apologies! Let's first discuss the possible approaches in the parent issue. Maybe, we can also expose just a single method that checks whether a block is synced. Otherwise, the array iteration method tagged in the comment would work great as well. But, I believe we should first establish if this is intended. |
|
Thanks for working on this, @yogeshbhutkar! As discussed above, we'd rather not add a new public |
What, Why and How?
While determining the
Block Information, theNavigationblock is incorrectly excluded as asynced block. This PR addresses and resolves that issue.Testing Instructions
site editor.Navigationblock.Block Card.Screenshots
Closes: #68646