Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
marked this pull request as ready for review
September 21, 2026 15:20
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
added this pull request to stack #82877
September 21, 2026 15:30
desrosj
removed this pull request from stack #82877
September 22, 2026 16:34
desrosj
changed the base branch from
fix-actions-6.9/guard-setaccessible-php85
to
wp/6.9
September 22, 2026 16:34
desrosj
force-pushed
the
fix-actions-6.9/pin-wp-version-performance-tests
branch
from
September 22, 2026 16:36
0d5efd1 to
b04953e
Compare
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/remove-disabled-mobile-unit-js
September 22, 2026 17:00
desrosj
added this pull request to stack #83392
September 22, 2026 17:00
…ch filter, so PRs opened against this branch still get fixed-issue assignment and first-time-contributor labeling.
desrosj
removed this pull request from stack #83392
September 22, 2026 21:52
desrosj
changed the base branch from
fix-actions-6.9/remove-disabled-mobile-unit-js
to
wp/6.9
September 22, 2026 21:52
desrosj
force-pushed
the
fix-actions-6.9/pin-wp-version-performance-tests
branch
from
September 22, 2026 23:25
b04953e to
836bbad
Compare
desrosj
changed the base branch from
wp/6.9
to
fix-actions-6.9/remove-disabled-mobile-unit-js
September 22, 2026 23:26
desrosj
added this pull request to stack #83413
September 22, 2026 23:26
desrosj
removed this pull request from stack #83413
September 28, 2026 15:44
desrosj
changed the base branch from
fix-actions-6.9/remove-disabled-mobile-unit-js
to
wp/6.9
September 28, 2026 15:45
…nit-js-date jobs.
…h-triggered tasks (`add-milestone`, `first-time-contributor-account-link`) both bail out immediately outside of `trunk`, so running them here on every push does nothing.
…-js-date as well.
desrosj
force-pushed
the
fix-actions-6.9/pin-wp-version-performance-tests
branch
from
October 7, 2026 16:00
a04f6b5 to
8dc651e
Compare
desrosj
force-pushed
the
fix-actions-6.9/remove-disabled-mobile-unit-js
branch
from
October 7, 2026 16:00
42582f5 to
578f631
Compare
desrosj
removed this pull request from stack #83631
October 7, 2026 18:13
desrosj
changed the base branch from
fix-actions-6.9/remove-disabled-mobile-unit-js
to
wp/6.9
October 7, 2026 18:14
Member
Author
|
Closing: the performance tests workflow is removed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82785.
What?
Change the WordPress version the
pull_requestperformance comparison installs from6.8to6.9in.github/workflows/performance.yml:- name: Compare performance with base branch if: github.event_name == 'pull_request' - run: ./bin/plugin/cli.js perf "$GITHUB_SHA" "$GITHUB_BASE_REF" --tests-branch "$GITHUB_SHA" --wp-version "6.8" + run: ./bin/plugin/cli.js perf "$GITHUB_SHA" "$GITHUB_BASE_REF" --tests-branch "$GITHUB_SHA" --wp-version "6.9"Nothing else in the workflow changes.
Why?
bin/plugin/commands/performance.jswrites its own.wp-env.jsonfor each performance run, and--wp-version X.Ymakes it installhttps://wordpress.org/wordpress-X.Y.zipas that environment's WordPress Core. Pinning6.8therefore benchmarks pull requests against WordPress 6.8, while this branch's own.wp-env.jsonpins"core": "WordPress/WordPress#6.9-branch"and every other test environment on the branch runs against 6.9 — a one-major-release mismatch between the branch's performance job and everything else it tests with.The
6.8value was deliberate when it was written, and is now obsolete — not a typo. It was added to this branch by #73025 ("Revert: template activation", commit1fcf7478c5, merged 2025-11-06 withwp/6.9as its base). That same commit set.wp-env.json's"core"fromWordPress/WordPresstoWordPress/WordPress#6.8.3, and its description states the reason directly:So
--wp-version "6.8"and the6.8.3core pin were a matched pair of temporary pins, added because reverting template activation from the plugin left it incompatible with the then-in-development WordPress 6.9 thatWordPress/WordPresstrunk was tracking.Both halves of that workaround have since expired:
.wp-env.jsonfromWordPress/WordPress#6.8.3toWordPress/WordPress#6.9-branch.performance.ymlwas simply not updated alongside it, which is what leaves the two out of sync today.WordPress/WordPress's6.9-branchhas no static-templates controller inwp-includes/rest-api/endpoints/), so there is nothing left for the pin to protect against.WordPress 6.9 is also a released version now, so the URL
--wp-version "6.9"resolves to —https://wordpress.org/wordpress-6.9.zip— exists (verified:HTTP 200, ~28 MB). When6.8was written, 6.9 was still the in-development version being tracked byWordPress/WordPresstrunk, so6.8was the newest release available to pin to at that point.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code