Repository navigation
Remove npm from package engines - #83326
Conversation
🤖 PR meta 🤖📦 Bundle sizeSize Change: 0 B Total Size: 8.21 MB
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
left a comment
There was a problem hiding this comment.
Nice cleanup, thanks!
I think there's a bug we need to fix with check-engines.
See inline comments for a few other minor things
tyxla
left a comment
There was a problem hiding this comment.
LGTM from my perspective.
Left a couple of minor things for your consideration before 🚢
What?
Removes
npmfrom theenginesfield of every workspace package, keepingnode.Why?
engines.npmonly constrains consumers who install with npm; pnpm and Yarn ignore it, so it says nothing about package manager compatibility. The values (>=8.19.2,>=10.2.3) are just the npm bundled with the declared Node minimum, so they add no information and can only produce spuriousEBADENGINEwarnings orengine-strictfailures. Contributor tooling is already pinned at the root viaenginesanddevEngines, which stay unchanged.How?
engines.npmfrompackages/*/package.jsonandtools/pr-meta/package.json.package-lock.json.package.jsonin packages/README.md.Testing Instructions
npm cicompletes without lockfile changes.npm run lint:pkg-jsonpasses.git grep '"npm": ">=' -- 'packages/*/package.json'returns nothing.Use of AI Tools
Changes were made with Claude Code and reviewed by me.