Skip to content

Remove npm from package engines - #83326

Merged
manzoorwanijk merged 3 commits into
trunkfrom
chore/remove-npm-engines-from-packages
Sep 22, 2026
Merged

manzoorwanijk merged 3 commits into
trunkfrom
chore/remove-npm-engines-from-packages

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Member

What?

Removes npm from the engines field of every workspace package, keeping node.

Why?

engines.npm only constrains consumers who install with npm; pnpm and Yarn ignore it, so it says nothing about package manager compatibility. The values (>=8.19.2, >=10.2.3) are just the npm bundled with the declared Node minimum, so they add no information and can only produce spurious EBADENGINE warnings or engine-strict failures. Contributor tooling is already pinned at the root via engines and devEngines, which stay unchanged.

How?

  • Dropped engines.npm from packages/*/package.json and tools/pr-meta/package.json.
  • Updated the matching workspace entries in package-lock.json.
  • Updated the example package.json in packages/README.md.

Testing Instructions

  1. npm ci completes without lockfile changes.
  2. npm run lint:pkg-json passes.
  3. git grep '"npm": ">=' -- 'packages/*/package.json' returns nothing.

Use of AI Tools

Changes were made with Claude Code and reviewed by me.

@github-actions github-actions Bot added [Package] Element /packages/element [Package] Date /packages/date labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 8.21 MB

a93fe49 Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric ec98b27 trunk % Change
timeToFirstByte 56.25 ms +4.09% -4.18% 54.95 ms +7.28% -2.46% 2.37%
largestContentfulPaint 92 ms +6.52% -4.35% 90 ms +8.89% -2.22% 2.22%
lcpMinusTtfb 34.65 ms +16.59% -1.3% 34.1 ms +19.35% -4.25% 1.61%
wpBeforeTemplate 26.96 ms +9.01% -1.52% 26.87 ms +12.58% -0.82% 0.33%
wpTemplate 23.92 ms +8.7% -2.59% 23.82 ms +3.95% -1.68% 0.42%
wpTotal 52.29 ms +3.69% -4.3% 51.01 ms +7.82% -2.41% 2.51%
wpMemoryUsage 7.59 MB +0% -0% 7.56 MB +0% -0% 0.38%
wpDbQueries 17 +0% -0% 17 +0% -0% 0%

front-end-classic-theme

Metric ec98b27 trunk % Change
timeToFirstByte 44.65 ms +7.73% -1.23% 44.7 ms +8.61% -2.24% -0.11%
largestContentfulPaint 100 ms +4% -2% 100 ms +4% -4% 0%
lcpMinusTtfb 55.35 ms +3.43% -3.97% 54.65 ms +2.1% -3.93% 1.28%
wpBeforeTemplate 23.63 ms +2.62% -1.02% 23.64 ms +10.41% -1.4% -0.04%
wpTemplate 17.76 ms +5.63% -2.2% 17.9 ms +2.74% -3.02% -0.78%
wpTotal 41.37 ms +7.71% -0.92% 41.6 ms +9.04% -2.31% -0.55%
wpMemoryUsage 6.20 MB +0% -0% 6.17 MB +0% -0% 0.48%
wpDbQueries 14 +0% -0% 14 +0% -0% 0%

media-processing

Metric ec98b27 trunk % Change
mediaProcessingJpeg 413.89 ms +6.1% -1.19% 410.91 ms +1.78% -0.81% 0.73%
mediaProcessingAvif 6180.72 ms +0.28% -0.04% 6200.71 ms +0.23% -0.16% -0.32%
mediaProcessingJpegToAvif 4308.8 ms +0.34% -0.19% 4325.75 ms +0.47% -0.13% -0.39%

media-upload

Metric ec98b27 trunk % Change
jpegUploadProcessing 1434.96 ms +4.47% -1.41% 1414.29 ms +0.67% -0.74% 1.46%
pngUploadProcessing 216.53 ms +6.61% -5.07% 210.62 ms +4.11% -4.52% 2.81%
largeJpegUploadProcessing 1413.82 ms +0.56% -0.27% 1416.87 ms +0.66% -0.79% -0.22%
multipleImageUploadProcessing 1607.86 ms +0.28% -2.46% 1544.78 ms +0.45% -0.98% 4.08%

post-editor

Metric ec98b27 trunk % Change
serverResponse 327.13 ms +1.54% -8.96% 332.07 ms +4.36% -9.42% -1.49%
firstPaint 177.16 ms +17.67% -10.45% 196.43 ms +16.52% -21.24% -9.81%
domContentLoaded 839.67 ms +0.7% -0.81% 834.52 ms +0.36% -0.47% 0.62%
loaded 840.73 ms +0.7% -0.8% 835.61 ms +0.4% -0.47% 0.61%
firstContentfulPaint 353.68 ms +2.01% -0.46% 345.36 ms +1.15% -2.39% 2.41%
firstBlock 2449.07 ms +0.76% -1.35% 2454.05 ms +1.15% -0.86% -0.2%
type 17.37 ms +2.76% -10.42% 17.38 ms +5.64% -4.09% -0.06%
typeWithoutInspector 17.12 ms +6.07% -1.11% 16.96 ms +2.71% -3.54% 0.94%
typeWithTopToolbar 21.51 ms +5.25% -3.35% 20.97 ms +4.96% -1.86% 2.58%
typeContainer 7.65 ms +6.54% -3.79% 7.1 ms +13.24% -6.34% 7.75%
focus 57.96 ms +4.81% -3.85% 56.41 ms +7.98% -4.68% 2.75%
firstFocus 175.76 ms +0% -0% 151.11 ms +0% -0% 16.31%
selectAll 386.27 ms +2.62% -3.34% 420.61 ms +0.83% -6.64% -8.16%
listViewOpen 52.99 ms +8.25% -4.68% 55.3 ms +5.1% -12.53% -4.18%
inserterOpen 19.15 ms +7.05% -8.09% 20.18 ms +7.73% -9.46% -5.1%
inserterHover 2.57 ms +6.23% -5.06% 2.8 ms +10% -8.57% -8.21%
inserterSearch 6.49 ms +7.4% -6.16% 6.98 ms +5.01% -6.02% -7.02%
loadPatterns 508.63 ms +0.66% -2.26% 544.54 ms +4% -2.08% -6.59%
wpTotal 318.4 ms +1.49% -9.25% 322.66 ms +4.62% -9.44% -1.32%
wpMemoryUsage 13.13 MB +0% -0% 13.10 MB +0% -0% 0.23%
wpDbQueries 54 +0% -0% 54 +0% -0% 0%

site-editor

Metric ec98b27 trunk % Change
serverResponse 392.52 ms +5.3% -6.28% 401.45 ms +3.92% -2.47% -2.22%
firstPaint 248.15 ms +10.99% -10.69% 238.01 ms +19.18% -10.56% 4.26%
domContentLoaded 1117.73 ms +0.86% -1.52% 1114.54 ms +1.05% -1.85% 0.29%
loaded 1118.82 ms +0.87% -1.51% 1115.82 ms +1.03% -1.86% 0.27%
firstContentfulPaint 442.13 ms +3.54% -2.62% 445.61 ms +1.73% -2.21% -0.78%
firstBlock 3956.08 ms +0.12% -0.39% 3911.68 ms +0.52% -0.52% 1.14%
type 20.77 ms +2.99% -2.41% 21.28 ms +1.83% -6.02% -2.4%
navigate 125.5 ms +6.72% -9.27% 119.95 ms +13.81% -2.68% 4.63%
loadPatterns 1303.74 ms +26.94% -3.5% 1393.79 ms +13.12% -13.63% -6.46%
loadPages 1093.89 ms +2.02% -0.91% 1125.19 ms +0.48% -2.44% -2.78%
wpTotal 381.58 ms +5.41% -6.47% 390.43 ms +4.03% -2.5% -2.27%
wpMemoryUsage 12.10 MB +0% -0% 12.06 MB +0% -0% 0.36%
wpDbQueries 43.5 +1.15% -1.15% 43 +2.33% -0% 1.16%

a93fe49 Run

@github-actions github-actions Bot added [Package] Data /packages/data [Package] Server Side Render /packages/server-side-render [Package] A11y /packages/a11y [Package] Autop /packages/autop [Tool] Babel preset /packages/babel-preset-default [Tool] Browserslist config /packages/browserslist-config [Package] DOM ready /packages/dom-ready [Package] Hooks /packages/hooks [Package] i18n /packages/i18n [Package] is-shallow-equal /packages/is-shallow-equal [Tool] npm-package-json-lint config /packages/npm-package-json-lint-config [Tool] WP Scripts /packages/scripts [Package] Url /packages/url [Package] Word count /packages/wordcount [Package] Deprecated packages/deprecated [Tool] Babel plugin makepot /packages/babel-plugin-makepot [Tool] Babel plugin import JSX pragma /packages/babel-plugin-import-jsx-pragma [Package] Blob /packages/blob [Package] Compose /packages/compose [Package] Core data /packages/core-data [Package] API fetch /packages/api-fetch [Package] HTML entities /packages/html-entities [Package] Viewport /packages/viewport [Package] DOM /packages/dom [Package] Keycodes /packages/keycodes [Package] Plugins /packages/plugins labels Sep 22, 2026
@github-actions github-actions Bot added [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Tool] Env /packages/env [Package] E2E Tests /packages/e2e-tests [Tool] Prettier config /packages/prettier-config [Package] Project management automation /packages/project-management-automation [Package] Escape HTML /packages/escape-html [Package] Interface /packages/interface [Package] Primitives /packages/primitives [Package] Icons /packages/icons [Tool] stylelint config /packages/stylelint-config [Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Package] Lazy import /packages/lazy-import [Package] Edit Site /packages/edit-site [Package] Base styles /packages/base-styles [Tool] PostCSS Plugins Preset /packages/postcss-plugins-preset [Package] Warning /packages/warning [Package] React i18n /packages/react-i18n [Tool] Readable JS Assets Webpack Plugin /packages/readable-js-assets-webpack-plugin [Package] Style Engine /packages/style-engine [Package] Preferences /packages/preferences [Package] Media Utils /packages/media-utils [Package] Private APIs /packages/private-apis [Package] Commands /packages/commands [Package] Core commands /packages/core-commands [Package] Interactivity /packages/interactivity labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@tyxla tyxla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks!

I think there's a bug we need to fix with check-engines.

See inline comments for a few other minor things

Comment thread packages/scripts/package.json
Comment thread packages/README.md Outdated

@tyxla tyxla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my perspective.

Left a couple of minor things for your consideration before 🚢

Comment thread packages/scripts/scripts/check-engines.js Outdated
Comment thread packages/scripts/scripts/check-engines.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] A11y /packages/a11y [Package] Abilities /packages/abilities [Package] Admin UI /packages/admin-ui [Package] API fetch /packages/api-fetch [Package] Autop /packages/autop [Package] Base styles /packages/base-styles [Package] Blob /packages/blob [Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Package] Blocks /packages/blocks [Package] Boot /packages/boot [Package] Commands /packages/commands [Package] Components /packages/components [Package] Compose /packages/compose [Package] Core commands /packages/core-commands [Package] Core data /packages/core-data [Package] Data Controls /packages/data-controls [Package] Data /packages/data [Package] DataViews /packages/dataviews [Package] Date /packages/date [Package] Deprecated packages/deprecated [Package] Design System MCP /packages/design-system-mcp [Package] DOM ready /packages/dom-ready [Package] DOM /packages/dom [Package] E2E Tests /packages/e2e-tests [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Package] Editor /packages/editor [Package] Element /packages/element [Package] Escape HTML /packages/escape-html [Package] Fields /packages/fields [Package] Format library /packages/format-library [Package] Grid /packages/grid [Package] Hooks /packages/hooks [Package] HTML entities /packages/html-entities [Package] i18n /packages/i18n [Package] Icons /packages/icons [Package] Image Cropper Related to packages/image-cropper [Package] Interactivity Router /packages/interactivity-router [Package] Interactivity /packages/interactivity [Package] Interface /packages/interface [Package] is-shallow-equal /packages/is-shallow-equal [Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Package] Keycodes /packages/keycodes [Package] Lazy import /packages/lazy-import [Package] Media Utils /packages/media-utils [Package] Notices /packages/notices [Package] Patterns /packages/patterns [Package] Plugins /packages/plugins [Package] Preferences /packages/preferences [Package] Primitives /packages/primitives [Package] Priority Queue /packages/priority-queue [Package] Private APIs /packages/private-apis [Package] Project management automation /packages/project-management-automation [Package] React i18n /packages/react-i18n [Package] Redux Routine /packages/redux-routine [Package] Rich text /packages/rich-text [Package] Router /packages/router [Package] Server Side Render /packages/server-side-render [Package] Style Engine /packages/style-engine [Package] Sync /packages/sync [Package] Theme /packages/theme [Package] Token List /packages/token-list [Package] UI /packages/ui [Package] Url /packages/url [Package] Viewport /packages/viewport [Package] Views /packages/views [Package] Warning /packages/warning [Package] Widget Dashboard /packages/widget-dashboard [Package] Widget primitives /packages/widget-primitives [Package] Word count /packages/wordcount [Package] wp-build /packages/wp-build [Tool] Babel plugin import JSX pragma /packages/babel-plugin-import-jsx-pragma [Tool] Babel plugin makepot /packages/babel-plugin-makepot [Tool] Babel preset /packages/babel-preset-default [Tool] Browserslist config /packages/browserslist-config [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Tool] Docgen /packages/docgen [Tool] E2E Test Utils /packages/e2e-test-utils-playwright [Tool] Env /packages/env [Tool] ESLint plugin /packages/eslint-plugin [Tool] npm-package-json-lint config /packages/npm-package-json-lint-config [Tool] PostCSS Plugins Preset /packages/postcss-plugins-preset [Tool] Prettier config /packages/prettier-config [Tool] Readable JS Assets Webpack Plugin /packages/readable-js-assets-webpack-plugin [Tool] stylelint config /packages/stylelint-config [Tool] WP Scripts /packages/scripts [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants