Skip to content

Repair wp/6.4 branch Actions: Remove the redundant Install NVM step - #83693

Closed
desrosj wants to merge 53 commits into
wp/6.4from
fix-actions-6.4/remove-install-nvm-step
Closed

desrosj wants to merge 53 commits into
wp/6.4from
fix-actions-6.4/remove-install-nvm-step

Conversation

@desrosj

@desrosj desrosj commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Part of #82929.

What?

Removes the Install NVM step from .github/workflows/performance.yml.

Why?

nvm is already installed on GitHub-hosted Ubuntu runners, in $HOME/.nvm. The step's own output says so (=> nvm is already installed in /home/runner/.nvm, trying to update using git), so on every run it only downloads and re-runs the nvm v0.39.1 install script over the existing copy.

Nothing else in the workflow uses the step: the performance CLI loads nvm itself with source $HOME/.nvm/nvm.sh, which the preinstalled copy provides.

Upstream

trunk no longer has this step. It was removed in #82160 ("Performance tests: Build once and shard the suites across parallel CI jobs") as part of a larger rework of the workflow, which isn't ported here.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

…ch filter, so PRs opened against this branch still get fixed-issue assignment and first-time-contributor labeling.
…h-triggered tasks (`add-milestone`, `first-time-contributor-account-link`) both bail out immediately outside of `trunk`, so running them here on every push does nothing.
@desrosj desrosj added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 28, 2026
@desrosj desrosj self-assigned this Sep 28, 2026
@desrosj
desrosj added this pull request to stack #83694 September 28, 2026 19:40
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2882fc50-722f-4e8f-baf4-21303d4df7a3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #83694 September 28, 2026 23:46
@desrosj
desrosj added this pull request to stack #83741 September 28, 2026 23:46
@desrosj
desrosj force-pushed the fix-actions-6.4/remove-install-nvm-step branch from bf792a9 to a023ab0 Compare October 2, 2026 20:00
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-flaky-router-navigate-test branch from 6155f99 to 38e5372 Compare October 2, 2026 20:00
@desrosj
desrosj removed this pull request from stack #83741 October 7, 2026 18:11
@desrosj
desrosj changed the base branch from fix-actions-6.4/fix-flaky-router-navigate-test to wp/6.4 October 7, 2026 18:13
@desrosj

desrosj commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Closing: the performance tests workflow is removed from wp/6.4 in #83667, so this pull request has nothing left to change.

@desrosj desrosj closed this Oct 7, 2026
@desrosj
desrosj deleted the fix-actions-6.4/remove-install-nvm-step branch October 7, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant