Skip to content

feat: write reserved rows with recording off, so post locks use wp_set_presence() - #752

Merged
josephfusco merged 2 commits into
mainfrom
feat/reserved-rows-skip-recording
Oct 5, 2026
Merged

josephfusco merged 2 commits into
mainfrom
feat/reserved-rows-skip-recording

Conversation

@josephfusco

@josephfusco josephfusco commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Any reserved _ client ID is now written with recording off, which is wider than the lock's own reasoning that it holds only what core's post meta did, and a lock window filtered below one second is the one input left untested.

Fixes #751

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Fable 5.1
Used for: Making the change and tests, and running PHPCS, PHPStan and PHPUnit locally.

@josephfusco josephfusco added this to the 0.15.0 milestone Oct 5, 2026
@josephfusco josephfusco added [Type] Enhancement A suggestion for improvement of an existing feature [Area] Post Lock Bridge Issues for the post-lock bridge Public API Adds a hook, route, constant, or global that third parties can depend on labels Oct 5, 2026
@github-actions github-actions Bot removed the Public API Adds a hook, route, constant, or global that third parties can depend on label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🛝 WordPress Playgrounds

Built from 67881d3

Post locks RTC Settings
Single site Launch post locks, single site Launch RTC, single site Launch settings, single site
Multisite Launch post locks, multisite Launch RTC, multisite Launch network settings, multisite

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.55%. Comparing base (1ac34ce) to head (67881d3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #752   +/-   ##
=========================================
  Coverage     94.55%   94.55%           
  Complexity      268      268           
=========================================
  Files            29       29           
  Lines          3966     3966           
=========================================
  Hits           3750     3750           
  Misses          216      216           
Flag Coverage Δ
multisite 94.55% <100.00%> (ø)
phpunit 73.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions Bot added a commit that referenced this pull request Oct 5, 2026
@josephfusco
josephfusco marked this pull request as ready for review October 5, 2026 22:47
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@josephfusco
josephfusco merged commit 23dde0b into main Oct 5, 2026
25 checks passed
@josephfusco
josephfusco deleted the feat/reserved-rows-skip-recording branch October 5, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Post Lock Bridge Issues for the post-lock bridge [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post locks, the first consumer, are not written through the public API

1 participant