Skip to content

[install] There is no uninstall target created by CMake #619

Closed

Description

@FreddieOliveira

I'm upgrading from v1.3.1 to v1.4.0 in my Ubuntu 16.04 and I want to do a clean install. So I entered the v.1.3.1 folder that I had previously compiled and generated the Makefile and ran make uninstall but the rule uninstall doesn't exist. Is there an easy way to uninstall it that doesn't involve searching and deleting all files manually from my system?

Activity

  1. xor-gate commented on Jul 18, 2017

    @xor-gate
    Contributor

    There is currently no uninstall target created with CMake. It has not been implemented but this is what they explain on the wiki: https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake

  2. added this to the milestone on Jul 18, 2017
  3. changed the title [-]Cannot find easy way to uninstall[/-] [+]There is not uninstall target created by CMake[/+] on Jul 18, 2017
  4. FreddieOliveira commented on Jul 18, 2017

    @FreddieOliveira
    Author

    Thank you

  5. modified the milestones: , on Feb 19, 2020
  6. modified the milestones: , , on Mar 14, 2020
  7. Nightwalker-87 commented on Mar 25, 2020

    @Nightwalker-87
    Member

    @FreddieOliveira: What about make clean and delete the project folder afterwards? As far as I am aware of, currently no files are spread throughout the system in linux/unix environments apart from manual settings such as udev- or modprobe-rules. Please correct me if this is wrong.

    What do others think about implementing an uninstall target?

  8. FreddieOliveira commented on Mar 25, 2020

    @FreddieOliveira
    Author

    What about make clean and delete the project folder afterwards?

    Deleting the build directory would only purge the files inside it, leaving the ones added by the make install still hanging around on my system.

    As far as I am aware of, currently no files are spread throughout the system

    Version 1.3.1 was released February 2017 whereas version 1.4 was released in July that year. There's no way I would remember exactly which files were added to my system when make install was issued 5 months earlier. I didn't know by that time the Cmake creates a file called install_manifest.txt which lists all files added to your system, so in my mind the only solution was to run the make install again and check its output, or to use find.

    Although the @xor-gate solution ( xargs rm < install_manifest.txt) works flawless, it'd still be nice to have an uninstall target.

  9. 19 remaining items

  10. FreddieOliveira commented on Apr 6, 2020

    @FreddieOliveira
    Author

    But I don't get it, https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake suggests modifying CMakeLists.txt and creating a new file make_uninstall.cmake.in, but none of these changes were made.

    I took my time however to contribute helping you guys with this pull request: #907

  11. Nightwalker-87 commented on Apr 6, 2020

    @Nightwalker-87
    Member

    No! I did implement that - look at the referenced commit (17 hours ago) just before I asked you to test. This targeted that commit of course. You seem to have tried with an older commit.
    Now you have created a duplicate of that.

  12. FreddieOliveira commented on Apr 6, 2020

    @FreddieOliveira
    Author

    Ooh, now I see. This was pushed into the ext_pkg_versions branch, I was testing with the master. My bad.

    Indeed it fixes, thanks. Closing the issue as well as the duplicated PR. Just to know, when you intend to merge this into the master branch?

  13. Nightwalker-87 commented on Apr 6, 2020

    @Nightwalker-87
    Member

    Good, so it's not related to #804 then.

    Yes, it will merge into the next release v1.6.1. You can track the related milestone. It's description should provide you with all info there is so far, including the release date (may be subject to change though, depending on progress). It is updated regularly so you should not worry to miss anything.

    If you want to keep track with current changes and fixes, please stay on the develop branch.

  14. Nightwalker-87 commented on Apr 6, 2020

    @Nightwalker-87
    Member

    Fixed in commit e7ed76b.

  15. added a commit that references this issue on Apr 10, 2020
    44f6d81
  16. locked as resolved and limited conversation to collaborators on Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions