-
Notifications
You must be signed in to change notification settings - Fork 1.1k
SQC-707 Fix Hyperdrive binding slow latency on Windows #11443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQC-707 Fix Hyperdrive binding slow latency on Windows #11443
Conversation
🦋 Changeset detectedLatest commit: 529988a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dffbd2f to
6f432c0
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
e24787b to
d1f336d
Compare
It looks like this is the only implementation change in the PR. Just so I understand, can you explain how this improves the latency? If it was previously timing out wouldn't that be an error rather than slow? |
Never actually saw a timeout error when running |
I see. Thanks, that makes sense. |
jamesopstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've merged a PR to increase the test timeout so please bring this up to date with main before rerunning the tests.
Windows - Update localhost to 127.0.0.1 address to fix issue with Windows defaulting to ipv6 lookup and timing out - Fix skipped Windows Hyperdrive tests which were failing due to dispose causing connection reset errors. It was causing the child process to crash but this is now fixed with calling node spawn and cleanly handling windows connections errors
2825cce to
529988a
Compare
Fix Hyperdrive binding slow latency on Windows for
npx wrangler devcommandFixes #SQC-707
Customer reached out on discord reporting slow latency of 2000ms when using Hyperdrive binding and
localConnectionStringpointing at local db. Was able to reproduce on Windows 10 PC and get latency back to 8ms-15ms